Last modified: 2012-12-13 11:18:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40842, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38842 - Have separate API modules for changing labels and descriptions
Have separate API modules for changing labels and descriptions
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
storypoints: 5
:
Depends on:
Blocks: repoapi
  Show dependency treegraph
 
Reported: 2012-07-30 12:38 UTC by Daniel Kinzler
Modified: 2012-12-13 11:18 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2012-07-30 12:38:08 UTC
Currently, setlanguageattribute is used for setting labels and descriptions. This seems confusing and inconsistent in several ways.

* the name doesn't tell us what the module does.
* it seems inconsistent to be able to change the label and description at once, but not e.g. the aliases.
* generating translatable autoComments for every combination of adding/removing/updating labels and descriptions causes massive overhead, the number of translatable messages explodes.
* the UI does not allow for labels and descriptions to be changed at once anyway. This seems to me mostly useful during item creation, which uses the setitem module.
* conceptually. there should be one API module for every operation performed on the item. Each module is the equivalent of a function.
* if and when it is desirable to update both label and description in a single edit, it's always possible to use setitem.

So, if there is no compelling reason to be able to change a label and description with a single edit without using setitem, please split these operations into separate modules. Code can still be shared by using a common base class.
Comment 1 Anja Jentzsch 2012-11-29 12:39:15 UTC
Verified in Wikidata demo time for sprint 12

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links