Last modified: 2012-07-31 09:53:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40845, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38845 - Sites changes ordeer
Sites changes ordeer
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-30 13:41 UTC by jeblad
Modified: 2012-07-31 09:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description jeblad 2012-07-30 13:41:40 UTC
In the tests SitesTest.php at line 92 the following line gives an error

  array( array( 'global_key' => array( 'enwiki', 'dewiki' ) ), array( 'enwiki', 'dewiki' ) ),

while the following works

  array( array( 'global_key' => array( 'enwiki', 'dewiki' ) ), array( 'dewiki', 'enwiki' ) ),

The order is changed in Sites, but does not seem to happen always. Later a similar line does not trigger any error.
Comment 1 Daniel Kinzler 2012-07-30 19:12:53 UTC
What fails is the assertArrayEquals() in line 121, right? assertArrayEquals() should not care about the order of elements in the array (or the jeys, for that matter), unless you tell it to. There was in bug in assertArrayEquals() that made it fail if the order differed in some cases. I fixed that last friday. 

Please make sure you are using the latest version of the Wikidata branch that has the fix. The core fix was merged into master here: <https://gerrit.wikimedia.org/r/#/c/16754/>.

I'll close this as "works for me". If it still happens for you with the newest version of the Wikidata branch (even if only "sometimes"), please repopen the bug.
Comment 2 jeblad 2012-07-31 09:53:52 UTC
I later heard that there was a fix in master branch of core, but it hadn't yet been included in the Wikidata branch. It seems like it is fixed now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links