Last modified: 2014-02-18 19:00:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40902, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 38902 - VisualEditor: onbeforeunload throws Uncaught TypeError when leaving page from "Read" mode
VisualEditor: onbeforeunload throws Uncaught TypeError when leaving page from...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-01 01:15 UTC by Krinkle
Modified: 2014-02-18 19:00 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2012-08-01 01:15:24 UTC 
Steps to reproduce:
* Go to a page
* Switch to Edit mode
* Switch to Read mode
* Go to a different page (e.g. "View history" or "Main Page")

> Uncaught TypeError: Cannot call method 'getModel' of null
Comment 1 James Forrester 2012-08-01 01:44:19 UTC 
Either onbeforeunload() needs logic that we might have already torn down the surface and not complain if that's happened, or we need to not clean up after switching from the Edit tab to the Read tab. :-)
Comment 2 Krinkle 2012-08-01 06:33:56 UTC 
Also:

> Uncaught RangeError: Maximum call stack size exceeded
> >  jQuery.extend.proxy.proxy
> >  ve.init.mw.ViewPageTarget.onBeforeUnload
> >  jQuery.extend.proxy.proxy
> >  ve.init.mw.ViewPageTarget.onBeforeUnload
> >  [..]
> >  jQuery.extend.proxy.proxy
> >  ve.init.mw.ViewPageTarget.onBeforeUnload
> > jQuery.extend.proxy.proxy
> >  ve.init.mw.ViewPageTarget.onBeforeUnload
Comment 3 Trevor Parscal 2012-08-22 21:44:43 UTC 
Resolved in I13a2f02d256937b7da3aca3ad3c3404bd8f31244 by checking that the surface object was still around before using it.
Comment 4 James Forrester 2013-06-28 03:02:25 UTC 
Not fixed - that fixes a type error for undefined, not a range error.
Comment 5 James Forrester 2014-02-18 19:00:03 UTC 
Fixed a long time ago (September?). Closing.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links