Last modified: 2013-10-30 15:06:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40913, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38913 - Unneeded characters appear in the bubble on the map
Unneeded characters appear in the bubble on the map
Status: RESOLVED WONTFIX
Product: Wikipedia App
Classification: Unclassified
Near by (Other open bugs)
3.2 (iOS) / 1.2 (Android)
All All
: Low normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-01 09:35 UTC by Amir E. Aharoni
Modified: 2013-10-30 15:06 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot from iPhone showing the problem, by Siebrand. (93.46 KB, image/png)
2012-08-01 09:35 UTC, Amir E. Aharoni
Details
A screeshot that shows the same problem on Android, in the article Lijst van rijksmonumenten in Soestdijk (nl.wikipeda). The '{|' are at the wrong end, because of a different RTL bug. (388.29 KB, image/png)
2012-08-01 09:39 UTC, Amir E. Aharoni
Details

Description Amir E. Aharoni 2012-08-01 09:35:41 UTC
Created attachment 10916 [details]
Screenshot from iPhone showing the problem, by Siebrand.

Found by Siebrand:

In some articles unneeded characters appear in the bubble on the map.

To reproduce:

* Set the language in the app preferences to Dutch.
* Tap "Nearby".
* Find the town of Breukeln in Netherlands on the map.
* Find the marker for the article "Lijst van rijksmonumenten in Breukelen (plaats)". (I manually moved the map from where I am, in Israel, to Breukelen, and found this marker quite easily. Took me no more than minute.)
* Notice that in the end of the bubble there's the table syntax: {|. It shouldn't be there.

I also reproduced it on Android and attached screenshots. (The text in them is a bit weird because of Bug 38912, but you can still see the {| characters.)
Comment 1 Amir E. Aharoni 2012-08-01 09:39:41 UTC
Created attachment 10917 [details]
A screeshot that shows the same problem on Android, in the article Lijst van rijksmonumenten in Soestdijk (nl.wikipeda). The '{|' are at the wrong end, because of a different RTL bug.
Comment 2 Amir E. Aharoni 2012-08-01 09:41:04 UTC
Just a comment: May it can be "fixed" by changing the articles or the template that these articles use, but it probably happens in many articles and requires a general solution.
Comment 3 Maarten Dammers 2012-08-01 16:15:36 UTC
I'm not sure why you added me to the cc, but I do think I know what is causing this. 
* Take a look at https://nl.wikipedia.org/wiki/Lijst_van_rijksmonumenten_in_Soestdijk .
* Remove all templates from the wikitext, you'll get: De plaats '''[[Soestdijk]]''' telt 27 inschrijvingen in het '''[[rijksmonument]]enregister'''. Hieronder een overzicht.|}

You probably have a piece of code doing this stripping. Fix it to also strip off the table footer.
Comment 4 Amir E. Aharoni 2012-08-01 16:18:00 UTC
(In reply to comment #3)
> I'm not sure why you added me to the cc

Because it affects WLM-related pages and because you edited the nl.wikipedia templates that these pages use :)
Comment 5 Maarten Dammers 2012-08-01 16:39:05 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > I'm not sure why you added me to the cc
> 
> Because it affects WLM-related pages and because you edited the nl.wikipedia
> templates that these pages use :)

Ah, I have over 5 million edits so I guess the chance of running in one of them is maybe a bit higher than normal ;-)
Comment 6 Brion Vibber 2012-08-01 20:27:20 UTC
I think we're still getting those nearby lookups via geonames, so whatever's in their snippet is what we show...

Proper fix involves moving to querying our own database, and having/using a better snippet extractor?
Comment 7 Brion Vibber 2013-10-30 15:06:27 UTC
Old app is being retired, new app will be more like the mobile web's 'nearby' interface which works a different way.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links