Last modified: 2013-04-22 16:16:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41087, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39087 - If a user's default license is set to a license that isn't allowed in a campaign, the UploadWizard breaks
If a user's default license is set to a license that isn't allowed in a campa...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 37144
  Show dependency treegraph
 
Reported: 2012-08-06 22:07 UTC by Ryan Kaldari
Modified: 2013-04-22 16:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2012-08-06 22:07:54 UTC
If a user sets their default license to a license that isn't one of the license options for a campaign, the UploadWizard fails silently and doesn't let the user proceed past the Release Rights step.

The correct behavior here would for the license to be set to the default own work license for the campaign.
Comment 1 Maarten Dammers 2012-08-07 20:23:28 UTC
Ouch, that's serious breakage. Bumped it
Comment 2 Ryan Kaldari 2012-08-07 20:32:55 UTC
The only workaround in the meantime is to allow more license choices in the campaigns and hope no one has their default upload license set to PD-USGov-NASA :P
Comment 3 Maarten Dammers 2012-08-08 13:38:41 UTC
We're not offering users license options. My assumption is that this bug was introduced recently because we didn't run into this problems last year. 

We have several license related bugs at the moment. All seem to have introduced quite recently, maybe it's better to revert all that broken code back to the last stable state.
Comment 4 Ryan Kaldari 2012-08-20 21:48:48 UTC
Tracking down what code to revert is probably just as much work as fixing the bug :)
Comment 5 Mark Holmquist 2012-08-20 21:51:12 UTC
And I'm on it, anyway, so I'll fix it. No worries.

I'm also seeing some nasty code in this file, so that should get fixed, too.
Comment 6 Mark Holmquist 2012-08-20 22:51:44 UTC
https://gerrit.wikimedia.org/r/#/c/20829/

Nananananananana, Patch-man!
Comment 7 Ryan Kaldari 2012-08-27 19:37:33 UTC
Merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links