Last modified: 2012-08-08 16:21:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41091, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 39091 - jquery.wikiEditor.dialogs: 'missing' and 'invalid' properties should check against undefined instead of truthy


Summary:	jquery.wikiEditor.dialogs: 'missing' and 'invalid' properties should check ag...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikiEditor (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	MW 1.20 version
Assigned To:	Rob Moen

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-08-07 04:02 UTC by Codicorumus
Modified:	2012-08-08 16:21 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Codicorumus 2012-08-07 04:02:25 UTC

See module's code at https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/WikiEditor.git;a=blob;f=modules/jquery.wikiEditor.dialogs.config.js;h=76a3a57e27b6b7d87266171c26baf2a82d9f703a;hb=e7a0484eb56d72e5326282a54288580fdfcd144f

The if conditions at lines 201 and 203 must probably be corrected.

from :  if ( page.missing )
to   :  if ( page.missing !== undefined )

and

from :  if ( page.invalid )
to   :  if ( page.invalid !== undefined )

This code checks the api query result,
which, for instance, has
    page.missing === ""
if queried title doesn't exist.

As it is, the "Insert link" dialog shows "Page exists"
for every title inserted in the "Target page or URL:" field.

Comment 1 Codicorumus 2012-08-07 04:10:46 UTC

(In reply to comment #0)

Sorry for the link. I split the server part, so that could be read.

https://gerrit.wikimedia.org

/r/gitweb?p=mediawiki/extensions/WikiEditor.git;a=blob;f=modules/jquery.wikiEditor.dialogs.config.js;h=76a3a57e27b6b7d87266171c26baf2a82d9f703a;hb=e7a0484eb56d72e5326282a54288580fdfcd144f

Comment 2 Krinkle 2012-08-07 04:15:08 UTC

We also encountered this bug in the VisualEditor.

Assigning to Rob who already fixed this in VisualEditor, we should be able to
apply the same fix to WikiEditor.

Comment 3 Rob Moen 2012-08-07 17:56:55 UTC

This has already been fixed and was merged in July 31st.  
https://gerrit.wikimedia.org/r/#/c/17019/

Comment 4 Codicorumus 2012-08-08 16:21:41 UTC

Thank you!

Next time, I'll try to search a bit more, before entering a bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links