Last modified: 2012-08-07 21:37:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41107, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39107 - Summary and license headers on uploaded wiki page are badly formatted
Summary and license headers on uploaded wiki page are badly formatted
Status: RESOLVED FIXED
Product: WikiLoves Monuments Mobile
Classification: Unclassified
Upload (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-07 18:57 UTC by Jon
Modified: 2012-08-07 21:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2012-08-07 18:57:54 UTC
Currently files uploaded via the app do not render correctly as there is no new lines before the summary and license headers.

Instead of printing headers the == symbols are visible.

See 
http://test.wikipedia.org/w/index.php?title=File:Cathedral_of_Learning_(taken_on_3Aug2012_12hrs43mins17secs).jpeg&oldid=140280


(Raised via https://www.mediawiki.org/wiki/Wiki_Loves_Monuments_mobile_application/Feedback)
Comment 1 Brion Vibber 2012-08-07 21:22:21 UTC
Problem doesn't appear to be lack of newlines, but addition of lots of whitespace between the beginning of the line and the text.

Looks like a regression in commit 0ce8f5fedc484a362c4cb515f002a0d5ea8f35bc, which switched from generating a string to using the template library; the template source is heavily indented, which apparently is being preserved in the output.
Comment 2 Brion Vibber 2012-08-07 21:27:57 UTC
https://github.com/wikimedia/WLMMobile/pull/109 appears to fix it, please review :D

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links