Last modified: 2014-03-12 10:34:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41131, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 39131 - autoComment functionality needs tests for each Wikibase API module


Summary:	autoComment functionality needs tests for each Wikibase API module

Status:	NEW

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:	u=dev c=QA p=0
Keywords:	need-volunteer

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-08-08 10:31 UTC by Daniel Kinzler
Modified:	2014-03-12 10:34 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2012-08-08 10:31:51 UTC

The Autocomment class has generic tests, but each unit test for an API module should also check whether each API operation results in the correct autoComment being logged to the revision table.

Comment 1 Daniel Kinzler 2013-10-29 10:48:50 UTC

Adam, can you tell us what the status of this is? Perhaps it would be enough to test the summaries generated by ChangeOps?

Comment 2 Addshore 2013-10-29 12:06:06 UTC

currently summaries are tested for some api modules, toher have no tests for summaries.

An example of the current style of test for summary we have can be seen at

https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/tests/phpunit/includes/api/EditEntityTest.php#L263

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links