Last modified: 2013-11-12 16:23:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41136, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 39136 - replace Item::addSiteLink with Item::setSiteLink
replace Item::addSiteLink with Item::setSiteLink
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Low minor (vote)
: ---
Assigned To: Wikidata bugs
: need-volunteer
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-08 11:10 UTC by Daniel Kinzler
Modified: 2013-11-12 16:23 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2012-08-08 11:10:13 UTC 
Item::addSiteLink is inconsistent with the way Item::setLabel and Item::setDescription work, even though the operation is isomorphic to these.

The "updateType" parameter is really an abomination, and not really needed. The "set" mode suffices for labels and descriptions, so why not for links?
Comment 1 Lydia Pintscher 2013-10-19 17:11:06 UTC 
Is this still relevant?
Comment 2 Daniel Kinzler 2013-10-29 10:57:12 UTC 
We are using Item::addSimpleSiteLink now, which is still misnamed, but no longer has the confusing updateType parameter.

Closing for now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links