Last modified: 2012-08-10 14:00:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41156, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39156 - Update jquery.tablesorter to work with jQuery 1.8
Update jquery.tablesorter to work with jQuery 1.8
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.19
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-08 15:32 UTC by Sam Reed (reedy)
Modified: 2012-08-10 14:00 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2012-08-08 15:32:21 UTC
On jQuery 1.8RC1 the jquery.tablesorter.js tests fail:

https://gerrit.wikimedia.org/r/#/c/17455/

I'm not sure if this is a problem with jQuery 1.8RC1 (if so, we need to
upstream a bug), or it's a bug in tablesorter.

I've also no idea from which version of tablesorter ours was forked, no version information is kept

Current release version upstream:
 * Version 2.0.5b
 * @requires jQuery v1.2.3

http://tablesorter.com/docs/

Test failures:
jquery.tablesorter: Basic planet table: same value for multiple rows via
rowspan (1, 0, 1)Rerun
Died on test #1     at tableTest
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery.autoEllipsis%2CbyteLength%2CbyteLimit%2CcheckboxShiftClick%2Cclient%2CcolorUtil%2Ccookie%2CdelayedBind%2CgetAttrs%2ChighlightText%2Clocalize%2CmakeCollapsible%2CmessageBox%2Cmw-jump%2CmwExtension%2Cplaceholder%2Cqunit%2CtabIndex%2Ctablesorter%2CtextSelection%7Cjquery.qunit.completenessTest%7Cmediawiki.Title%2CUri%2Capi%2CjqueryMsg%2Clanguage%2Cspecial%2Cuser%2Cutil%7Cmediawiki.api.parse%7Cmediawiki.language.data%2Cinit%7Cmediawiki.legacy.ajax%2Cwikibits%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.special.javaScriptTest%2Crecentchanges%7Cmediawiki.tests.qunit.suites%2Ctestrunner&skin=vector&version=20120808T151944Z&*:168:725):
Syntax error, unrecognized expression: , tr
Source:     
Error: Syntax error, unrecognized expression: , tr
    at Function.Sizzle.error
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:69:124)
    at tokenize
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:72:858)
    at Sizzle.compile
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:74:427)
    at select
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:76:158)
    at select
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:78:190)
    at Sizzle
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:59:785)
    at multipleContexts
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:70:500)
    at handlePOSGroup
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:70:734)
    at handlePOS
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:71:714)
    at select
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:75:259)
jquery.tablesorter: Basic planet table: Same value for multiple rows via
rowspan II (1, 0, 1)Rerun
Died on test #1     at tableTest
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery.autoEllipsis%2CbyteLength%2CbyteLimit%2CcheckboxShiftClick%2Cclient%2CcolorUtil%2Ccookie%2CdelayedBind%2CgetAttrs%2ChighlightText%2Clocalize%2CmakeCollapsible%2CmessageBox%2Cmw-jump%2CmwExtension%2Cplaceholder%2Cqunit%2CtabIndex%2Ctablesorter%2CtextSelection%7Cjquery.qunit.completenessTest%7Cmediawiki.Title%2CUri%2Capi%2CjqueryMsg%2Clanguage%2Cspecial%2Cuser%2Cutil%7Cmediawiki.api.parse%7Cmediawiki.language.data%2Cinit%7Cmediawiki.legacy.ajax%2Cwikibits%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.special.javaScriptTest%2Crecentchanges%7Cmediawiki.tests.qunit.suites%2Ctestrunner&skin=vector&version=20120808T151944Z&*:168:725):
Syntax error, unrecognized expression: , tr
Source:     
Error: Syntax error, unrecognized expression: , tr
    at Function.Sizzle.error
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:69:124)
    at tokenize
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:72:858)
    at Sizzle.compile
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:74:427)
    at select
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:76:158)
    at select
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:78:190)
    at Sizzle
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:59:785)
    at multipleContexts
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:70:500)
    at handlePOSGroup
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:70:734)
    at handlePOS
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:71:714)
    at select
(http://192.168.0.190/w/load.php?debug=false&lang=en-gb&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120808T151944Z:75:259)
Comment 1 Krinkle 2012-08-08 22:26:45 UTC
Next time try running with debug mode so the stack is more readable :)
Comment 3 Krinkle 2012-08-08 22:43:42 UTC
Upstream: https://github.com/jquery/sizzle/issues/141

Regression in latest RC indeed.
Comment 4 Sam Reed (reedy) 2012-08-10 13:55:34 UTC
1.8 is out, but luckily this had already been fixed... http://bugs.jquery.com/ticket/12153
Comment 5 Sam Reed (reedy) 2012-08-10 14:00:36 UTC
Confirmed test is no longer broken on 1.8

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links