Last modified: 2014-11-13 03:12:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41183, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39183 - Parsoid: noinclude/includeonly/onlyinclude sections break start-of-line context if section is stripped
Parsoid: noinclude/includeonly/onlyinclude sections break start-of-line conte...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
tokenizer (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-08 23:44 UTC by ssastry
Modified: 2014-11-13 03:12 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2012-08-08 23:44:26 UTC
Try echo "{{Welcome}}" | node parse.js

The opening section heading ==Welcome== is not parsed and is wrapped in <p> tags verbatim.
Comment 1 Gabriel Wicke 2012-08-09 00:36:01 UTC
The heading is preceded by a long noinclude section, which we don't handle as start-of-line transparent in the tokenizer. This will be hard to support since we still need to tokenize noinclude sections, and noinclude sections don't necessarily match up.

Maybe we could add a production for balanced nowiki sections that can include arbitrary content, which we could then treat as start-of-line transparent, just as we do right now for comments.
Comment 2 Arlo Breault 2014-11-13 03:12:06 UTC
The tokenizer handles <*include*> as SOL transparent these days, and the test case above parses just fine.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links