Last modified: 2012-09-10 18:24:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41290, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39290 - apply explicit lang and dir HTML attributes to country-specific data in the WLM app
apply explicit lang and dir HTML attributes to country-specific data in the W...
Status: RESOLVED FIXED
Product: WikiLoves Monuments Mobile
Classification: Unclassified
Browse (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-12 19:21 UTC by Amir E. Aharoni
Modified: 2012-09-10 18:24 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Amir I'm pretty confident this is a duplicate. Does this screenshot exhibit the correct behaviour? (99.07 KB, image/png)
2012-09-05 00:57 UTC, Jon
Details
addresses on monuments list (41.51 KB, image/png)
2012-09-05 22:03 UTC, Jon
Details

Description Amir E. Aharoni 2012-08-12 19:21:16 UTC
This report is based on some assumptions, which may be wrong :)

Some information in the app, such as addresses of monuments, is written in the language of the country. It may have a different direction from the language of the app.

A simple solution is probably to apply the language of the country to such information, and the direction of that language as HTML lang and dir elements. (If I understand correctly, the app is HTML-based.)
Comment 1 Jon 2012-08-21 22:26:45 UTC
I believe this is taken care of https://github.com/wikimedia/WLMMobile/blob/master/assets/www/js/app.js#L846

The problem however is that the css doesn't pay attention this. I believe yuvipanda was looking at this?

If this is indeed what you meant please close this ticket and comment on bug 39288

Thanks Amir! :)
Comment 2 Jon 2012-08-22 21:40:53 UTC
closing in favour of bug 39288.  Please reopen if this is not fixed.
Comment 3 Amir E. Aharoni 2012-08-31 21:53:11 UTC
Reopening. It's a particular issue that should be taken care of.

At least, the dir attribute must always be applied to addresses of monuments, even if it's ltr. Practically, the only country with RTL addresses this year is Israel, so apply dir="rtl" to addresses in Israel and dir="ltr" to addresses in other countries. In the future it may become more complicated, but this would be enough for now.
Comment 4 Jon 2012-09-05 00:57:02 UTC
Created attachment 11071 [details]
Amir I'm pretty confident this is a duplicate. Does this screenshot exhibit the correct behaviour?
Comment 5 Jon 2012-09-05 00:57:24 UTC
(If the above does then this is a duplicate of bug 39288)
Comment 6 Amir E. Aharoni 2012-09-05 05:07:35 UTC
The rendering on this screenshot is good. I was talking more about the street addresses in the monuments list and not on an individual monument.
Comment 7 Jon 2012-09-05 22:03:01 UTC
Created attachment 11074 [details]
addresses on monuments list

Unfortunately this fix didn't make it in for today's release but should be present in the next release.

If this image shows the problem fixed please close this ticket as a duplicate.
Comment 8 Jon 2012-09-10 18:24:45 UTC
Please reopen if this is not now fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links