Last modified: 2012-08-21 19:02:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41303, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39303 - Unknown error: "unknown-warning" on uploading previously deleted filenames
Unknown error: "unknown-warning" on uploading previously deleted filenames
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Highest critical with 4 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 39256 (view as bug list)
Depends on:
Blocks: 37144 39220
  Show dependency treegraph
 
Reported: 2012-08-13 12:32 UTC by Daniel P.
Modified: 2012-08-21 19:02 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel P. 2012-08-13 12:32:43 UTC
I tried today to upload several files on Commons through Upload Wizard (using Mozilla Firefox) and after uploading I receive "Unknown error: "unknown-warning".". I tried with Google Chrome and the result is the same.
I've also tried to upload the files on Test Wiki and I got the same unknown error.
Comment 1 Raimond Spekking 2012-08-13 12:35:33 UTC
Please try uploading with the old form. Do you get a better warning with it? Could help to isolate the "unknown".
Comment 2 Daniel P. 2012-08-13 12:48:03 UTC
I've managed to upload the file successfully using the old form. I haven't got any errors.
Comment 3 Razvan Socol 2012-08-13 18:39:21 UTC
The problem appears when the filename is too common (if it begins with IMG or DSC or other usual prefixes). See also https://commons.wikimedia.org/wiki/Commons:Upload_Wizard_feedback#unknown-warning and https://commons.wikimedia.org/wiki/File:Upload-wizard_-_unknown-warning,_upload_failed.jpg.
Comment 4 Mark Holmquist 2012-08-13 18:49:37 UTC
If you're using a bad filename like that, you shouldn't be able to proceed to the upload, it should error out.

I feel like I fixed something like this at one point, but I could be wrong. Possible fixes:

https://gerrit.wikimedia.org/r/#/c/7608/

https://gerrit.wikimedia.org/r/#/c/10995/

Thanks for the bug report, maybe someone will review my patches now :)

(I removed "all browsers" because there's no proof or even rumour that supports that, and removed "Windows 7" because apparently there's a known cause)

(also, "blocker" isn't warranted here, seriously)
Comment 5 Derk-Jan Hartman 2012-08-14 08:41:16 UTC
There are a lot of reports about this on the UW feedback page, we really should prioritize resolution of this issue a bit.
Comment 6 Alex Nordstrom 2012-08-15 19:23:11 UTC
(In reply to comment #4)
> If you're using a bad filename like that, you shouldn't be able to proceed to
> the upload, it should error out.

No, it should not error out at the point where it does not. At the moment, you get the uninformative "unknown-warning" message before you get to the "Describe" screen, where you'd get a chance to select the file name on the server. The Upload Wizard should not care what the file is called on the uploader's computer.

> (I removed "all browsers" because there's no proof or even rumour that supports
> that, and removed "Windows 7" because apparently there's a known cause)

Pretty sure all browsers are affected. We have reports from users of Opera, Safari and Firefox on Commons:Upload Wizard feedback, and I've confirmed it myself on Chromium.

> (also, "blocker" isn't warranted here, seriously)

I don't know what the severity definitions for this Bugzilla are, but it's serious enough that if this isn't fixed within the next couple of days, we'll probably have to look at changing the upload link to point to the old upload form again. When the process fails with an utterly unhelpful error message for a common use case, who knows how many contributions we're turning down a day? I'm counting 11 reports on Commons:Upload Wizard feedback in the last five days alone. And that's only from people who spotted the small feedback link and bothered to tell us. Most people probably don't.
Comment 7 Mark Holmquist 2012-08-16 16:25:47 UTC
Hi!

Recently, a patch to MediaWiki core [0] changed the behavior of API warnings. We now get those at the first step, even if we don't handle them necessarily.

Could you try to reproduce this bug, and let us know if it still occurs? If so, the solution would likely be very different from before this patch.

I'm not sure if this occurred before or after the change to the API was pushed to Commons, it may have changed in the past few days :)

[0] https://gerrit.wikimedia.org/r/#/c/9261/

Thanks!
Comment 8 herzi.pinki 2012-08-16 20:19:47 UTC
Hi,

we want to use the UW for the upcoming WLM2012 campaign in Austria because it makes things much simpler for beginners. At least that's what we thought.

(A lot of effort was spent to allow passing parameters to the UW exact for that very purpose.)

The UW must continue even with forbidden filenames (without explicit warning), as the user can change the filenames in the describe step later. Only than you can check for sound filenames. If a filename misses to match criteria, the message should make a clear statement about that. "Unknown error: "unknown-warning", for sure, isn't. 

a hint: My local filenames are quite long, containing date and time and processing steps (something like 20120630_19-00-10_01.2.jpg), I do not get the message mentioned above in the beginning, but I have to change the name in the describe step. So the workaround for the problem is to rename files on the local disk before uploading, but that's far from being obvious and convenient.

regards
Comment 9 Daniel P. 2012-08-18 13:56:06 UTC
I confirm that the bug still occurs when uploading forbidden filenames.
Comment 10 Erik Moeller 2012-08-19 02:14:38 UTC
*** Bug 39256 has been marked as a duplicate of this bug. ***
Comment 11 Erik Moeller 2012-08-19 02:16:52 UTC
This is indeed a major issue caused by the recent API change and we'll resolve it ASAP. In the meantime, renaming the file to a unique name should resolve the issue; if not, please report it here.
Comment 12 Arnav Sonara 2012-08-19 10:48:11 UTC
If I try to upload say DSC_0578.JPG from Aurora or Chrome, I get "Unknown Error : Unknown Warning" but if I use a Unique name I am not getting the error and am able to upload file successfully, but its really tedious to rename all the files first locally and then upload them. Hope this gets resolved sooner.
Comment 13 Maarten Dammers 2012-08-20 21:39:40 UTC
Bumped it to highest because now the UploadWizard has been disabled as default way of upload at Commons.
Comment 14 Erik Moeller 2012-08-20 23:50:10 UTC
This should now be fixed in production; please report if you're still getting this issue (and provide details about file name / contents if possible).

We still have a few cases to improve upon per https://www.mediawiki.org/wiki/Extension:UploadWizard/Error_behavior and the recent core API change, but we wanted to make sure we get this fix out the door ASAP.
Comment 15 Brion Vibber 2012-08-21 19:02:49 UTC
Confirmed that iOS 6 iPad simulator is able to get past this step on UploadWizard on Commons now. Yay!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links