Wikimedia Bugzilla is closed!

Created attachment 10965 [details]
Patch with proposed change

ZipDirectoryReaderError subclasses Exception, and sets the code property as a string. Php's documentation says this should be an int, so this is already a little bit weird.

Under Hiphop, calling the parent constructor without the second parameter will set the code property to 0, because the parameter defaults to 0. This leads to uploads breaking, because calls to getErrorCode return 0 rather than the code that was passed in.

The change renames the code property to errorCode, so it can't be confused with exception's code property, which should be an int.