Last modified: 2012-12-31 17:25:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41353, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 39353 - jquery.byteLimit should unbind previous limit when called again with a different value
jquery.byteLimit should unbind previous limit when called again with a differ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.20.x
All All
: Low enhancement (vote)
: 1.20.0 release
Assigned To: Krinkle
:
Depends on:
Blocks: 29467
  Show dependency tree / graph
 
Reported: 2012-08-14 21:35 UTC by Rainer Rillke @commons.wikimedia
Modified: 2012-12-31 17:25 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rainer Rillke @commons.wikimedia 2012-08-14 21:35:30 UTC 
Currently, each time, $node.byteLimit(number) is executed, a new handler is attached. That's not good practise for a jQuery-plugIn. It should use its own namespace (.bind('keypress.byteLimit')) and do .unbind('keypress.byteLimit') before assigning the next handler. 

Please implement this before Bug 29467 because it isn't funny to unbind all events myself, especially if the event-handlers have now own namespace. Thanks!
Comment 1 Krinkle 2012-12-31 17:25:29 UTC 
This was implemented as part of a rewrite.

Change-Id: I9c204243d0bdf7158aa86a62b591ce717a36fe27
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links