Last modified: 2012-11-29 12:40:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41366, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39366 - Use of edit token in ApiModifyItem
Use of edit token in ApiModifyItem
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on: 38963
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-15 08:40 UTC by jeblad
Modified: 2012-11-29 12:40 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description jeblad 2012-08-15 08:40:02 UTC
To make the API somewhat simpler, and possibly easier to maintain, the itemtoken should be removed in favor of the edittoken. The only real problem is that we can't change it to enforce serialization of some of the requests, but those calls could be handled separately.

Use of "gettoken" will be removed from wbgetitems and wbset*. All modules that use "token" will then supply edittoken and not itemtoken. The user interface is currently using edittoken and can continue to use that one. For API calls the edittoken is already available through action=tokens, and no changes are necessary there.

See also https://bugzilla.wikimedia.org/show_bug.cgi?id=35993
Comment 1 jeblad 2012-09-21 11:38:39 UTC
Local change in work, kill-gettoken-39366, not ready for review
Comment 2 jeblad 2012-09-24 09:42:51 UTC
Change I7cee30ea: Kill use of gettoken
Comment 3 jeblad 2012-09-24 09:45:23 UTC
When I tried to change the tests into using the edittoken (the UI already does that) I got a lot of failures and they seems to emerge from a session failure. There are some print statements in there that needs to be removed when the patchset works.
Comment 4 Anja Jentzsch 2012-11-29 12:40:04 UTC
Verified in Wikidata demo time for sprint 17

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links