Last modified: 2012-11-06 19:51:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41383, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 39383 - jquery.badge.js should return "this" (a reference to the jQuery object)


Summary:	jquery.badge.js should return "this" (a reference to the jQuery object)

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	JavaScript (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Andrew Garrett

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-08-15 16:11 UTC by Rainer Rillke @commons.wikimedia
Modified:	2012-11-06 19:51 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rainer Rillke @commons.wikimedia 2012-08-15 16:11:17 UTC

Usually you can do the following with jQuery plugIns:
* $('#mySelector').click(_myHandlerMethod).myFirstPlugin({ settings: '' }).mySecondPlugIn();

This is accomplished by returning the passed elements from the plugIn-method.

Comment 1 Krinkle 2012-08-16 17:09:45 UTC

Rephrase summary, there is no such thing as a "jQuery Node". jQuery objects are instances of jQuery which have an array-like collection internally with one or more element. We don't want to return the node, but the jQuery object itself (which the prototype methods for other plugins and built-in methods etc.).

Comment 2 Ryan Kaldari 2012-11-06 19:51:08 UTC

Fixed in https://gerrit.wikimedia.org/r/#/c/32091

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links