Last modified: 2012-09-12 17:33:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41386, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39386 - Clicking on region rapidly, multiple times, causes severe lag
Clicking on region rapidly, multiple times, causes severe lag
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
master
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: javascript
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-15 16:54 UTC by Mark Holmquist
Modified: 2012-09-12 17:33 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Holmquist 2012-08-15 16:54:14 UTC
Click five times, quickly, on "America". It's slow as all get out. What's more, it halts the browser (tested in FF 14.0.1)

There are several options I can think of:

1. Make it faster, so multiple clicks won't matter (much). This is hackish and unreliable.

2. Use proper callbacks combined with caching and tracking of requests--if a request already exists for the resource you're trying to get, don't start another one.

3. Remove the click event after the first click is fired, and replace it only after the user switches away from that region. This may work best, because it means no other handling, but it's complicated because you'll need to save the function definition, an anonymous function won't work here.

I report this bug knowing nothing about the structure of this extension, so don't think that these are the only options.
Comment 1 Siebrand Mazeland 2012-08-15 19:36:17 UTC
Can you clarify the use case of the described scenario?
Comment 2 Mark Holmquist 2012-08-15 19:43:18 UTC
It's not really a use case, it's just something that might happen, and the software shouldn't die when it does.
Comment 3 Santhosh Thottingal 2012-09-03 07:48:49 UTC
Can you confirm whether it fixed now?

We are caching the region filter results now and there were multiple optimizations in the code.
Comment 4 Santhosh Thottingal 2012-09-12 17:33:30 UTC
The performance fixes did in ULS seems to fix this and not able to reproduce in latest version.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links