Last modified: 2013-05-09 13:22:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41410, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39410 - Featuring oversight-requested posts
Featuring oversight-requested posts
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Matthias Mullie
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-16 01:44 UTC by Oliver Keyes
Modified: 2013-05-09 13:22 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2012-08-16 01:44:07 UTC
When I request oversight for some feedback, it will say that it's hidden and show that blue bar, but if I then press through to view the hidden contents, I can click on all the links on the right hand side that allow me to feature the post, un-hide it, unrequest oversight etc, but the one that allows you to feature the post should be disabled for any feedback that is hidden/oversighted.
Comment 1 Oliver Keyes 2012-09-20 14:41:56 UTC
Mattias, this bug has been sitting here for over a month. It needs to be worked on, or at least a comment provided as to why it hasn't been.

Similarly, you should not be able to mark feedback as resolved if it's got oversight requested, nor should you be able to do these things if the post is *hidden*.
Comment 2 Matthias Mullie 2012-09-24 16:03:36 UTC
Taking the first one as example (http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/Higgs_boson/150728), the reason appears to be the large amount of "helpful" votes (106-23=83), which means +83 on relevance score, making the score unusually high.
This keeps it at the top of the relevance-score based filter (which is the one anon users see by default) which makes it even more likely for users to mark it as helpful, ...
You get the picture.
Maybe we should only display feedback within the last month for the relevant filter (not yet sure how I'll implement this once sharded though, so other ideas are welcome as well)
Or we make sure that only a certain amount of positive actions count to the relevance score, a number that it just a bit under the negative score that hiding/resolving packs?

Also: it might help to have marking something as resolved also automatically unfeature the feedback post if it was previously featured (because it now keeps the 50 points it received upon featuring)
Had this been done, the feedback had probably never been up there for so long and it wouldn't have had the chance to run away from other articles.
Comment 3 Matthias Mullie 2012-09-24 16:05:19 UTC
Above comment is in wrong thread - belongs here: https://bugzilla.wikimedia.org/show_bug.cgi?id=39587
Comment 4 Oliver Keyes 2012-10-21 18:37:39 UTC
Can we please get some movement on this? Similarly, something can be both resolved and hidden. categories should be exclusionary, not inclusionary.
Comment 5 Matthias Mullie 2012-10-22 14:09:03 UTC
Pushed to Gerrit (https://gerrit.wikimedia.org/r/#/c/29304/) & prototype

One can no longer resolve/unresolve/feature/unfeature feedback that is hidden/oversighted (the controls won't even be there)
Comment 6 Oliver Keyes 2012-10-22 14:10:03 UTC
Okay. What if feedback is featured, and then hidden? Is featuring removed, or is the ability to un-feature it simply locked out?
Comment 7 Oliver Keyes 2012-10-22 14:10:12 UTC
that is, removed by hitting "hide"
Comment 8 Matthias Mullie 2012-10-22 14:14:32 UTC
it keeps the featured status & the ability to un-feature is gone (the FEATURED label will not be shown unless unhidden though)
Comment 9 Oliver Keyes 2012-10-22 14:15:22 UTC
Okay. How much of an additional PITA to just have the action of hiding or oversighting void all other flags?
Comment 10 Matthias Mullie 2012-10-22 14:27:59 UTC
Not much work. But we're building this weird scheme of "if you do this, than this and that automatically happens" and weird stuff is about to happen:

Assume we were to do this:
- someone requests oversight
  -> already leads to the post being auto-hidden
    -> will now lead to all other flags being voided

Makes sense, but there if later someone decides the oversight request was invalid, the previous flags are gone.. (at least, given the current schema; this could be changed, but will be quite some work)

So: not a lot of work, if you're willing to accept the above scenario.
Comment 11 Oliver Keyes 2012-10-22 14:59:53 UTC
Well, if someone decides the oversight request is invalid but it should remain hidden, that's cool. Experienced editors thinking something needs OS when it's actually a pretty swell comment is sort of an edge case.
Comment 12 Matthias Mullie 2012-10-22 15:24:38 UTC
Just to be sure: if I were to automatically void all current flags the moment that someone requests oversight (eg 4 helpful flags, 1 unhelpful & 1 featured - I guess abuse-flags shouldn't be voided?), they will never automatically be restored (not when unrequesting, not when denying the request, ..) - ok?
Comment 13 Oliver Keyes 2012-10-22 15:26:29 UTC
Fine from my POV. If the request is declined but the post remains hidden, none of those things matter, and I think the chances of anything legitimately and substantially weighted in a positive fashion being oversight-requested are slim.
Comment 14 Matthias Mullie 2012-11-05 12:58:55 UTC
Oliver: I've spun of this "void all other flags" into another bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=41777, as that change will have an impact on the scalability code as well (and in the current code, there should be failsafe mechanisms already to make sure that hidden feedback does not show up in other filters)
At least, we can then go ahead with this "lockout out featuring/resolving" change right away and figure out the other part when I get there :)
Comment 15 Matthias Mullie 2013-05-09 13:22:31 UTC
UI has now changed: after marking something as inappropriate, it is no longer possible to mark the same thing as useful, resolved, ... unless you first un-inappropriate it. A feedback entry now only has 1 status, so this report is no longer relevant.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links