Last modified: 2012-12-13 11:19:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41500, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39500 - get rid of getUsekeys setting
get rid of getUsekeys setting
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
storypoints: 1
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-20 11:21 UTC by Daniel Kinzler
Modified: 2012-12-13 11:19 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2012-08-20 11:21:26 UTC
which output format supports associative arrays is NOT a matter of configuration. The format either does, or it doesn't. 

Also, the current default for getUsekeys disables keys for the "php" and "wddx" formats - although associative arrays should work fine with these. As far as I know, only XML output does not support this (but this needs checking). 

So, Wikibase\Api::getUsekeys() should just return false for formats known not to support associative arrays / maps, and default to true otherwise. Test cases should be adapted accordingly.
Comment 1 denny vrandecic 2012-08-22 14:36:30 UTC
It seems that only XML should disable keys. So we can simply ask if it is XML. For all other formats, we can use keys. This should not be configurable.
Comment 2 jeblad 2012-08-24 08:16:59 UTC
I really don't like this because it locks the code to the existing formats. If someone makes a specialized format and wants to use this extension, then he must patch the extension to make it work with the new format if that does not support use of keys.

The present formats that does not support usekeys are XML (WDDX is encoded as XML) and their pretty formatted versions.
Comment 3 jeblad 2012-08-24 13:38:34 UTC
https://gerrit.wikimedia.org/r/#/c/21317/
Comment 4 Anja Jentzsch 2012-11-29 12:40:09 UTC
Verified in Wikidata demo time for sprint 14

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links