Last modified: 2013-01-15 23:48:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41520, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39520 - Cannot parse the Fila PCN template from es.wikipedia.org
Cannot parse the Fila PCN template from es.wikipedia.org
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
tokenizer (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks: 37872
  Show dependency treegraph
 
Reported: 2012-08-21 03:57 UTC by David E. Narváez
Modified: 2013-01-15 23:48 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description David E. Narváez 2012-08-21 03:57:56 UTC
You can see this template in action at

http://es.wikipedia.org/w/index.php?title=Anexo:Monumentos_Hist%C3%B3ricos_de_Panam%C3%A1&action=edit&section=7

another similar template that is not parsed correctly is Fila BIC. I'm trying to parse it with the following command

cat Darien.txt | node ./js/lib/parse.js --wgScript "http://es.wikipedia.org/w" --wgScriptPath "http://es.wikipedia.org/wiki/"

and I only get table headers in the output and a mention to a template but not even the name of the template.
Comment 1 Gabriel Wicke 2012-08-21 18:28:33 UTC
http://parsoid.wmflabs.org/es/Anexo:Monumentos_Hist%C3%B3ricos_de_Panam%C3%A1 produces some output, but it is clearly not quite correct. I have not yet looked into the included templates, but would not be surprised if this was an instance of mis-nested parser functions as described in http://www.mediawiki.org/wiki/Parsoid/limitations.
Comment 2 Gabriel Wicke 2012-10-03 22:28:18 UTC
The first noinclude end tag is tokenized as an attribute of the table tag:

echo '{{Plantilla:Fila_PCN}}' | nodejs parse.js --wgScript "http://es.wikipedia.org/w" --wgScriptPath "http://es.wikipedia.org/wiki/" --debug 2>&1 | less

(..)

    {
      "type": "TagTk",
      "name": "table",
      "attribs": [
        {
          "k": "</noinclude",
          "v": ""
        }
      ],
      "dataAttribs": {
        "tsr": [
          11,
          24
        ]
      },
      "tagToStringFns": {}
    }
Comment 3 Gabriel Wicke 2012-11-20 02:46:18 UTC
Tokenization has since been fixed, but round-tripping is still broken:

http://parsoid.wmflabs.org/_rt/es/Anexo:Monumentos_Hist%C3%B3ricos_de_Panam%C3%A1
Comment 4 ssastry 2012-11-20 20:20:14 UTC
Roundtripping fixed in https://gerrit.wikimedia.org/r/#/c/34335/
Comment 5 Gabriel Wicke 2013-01-15 23:48:06 UTC
A last issue with caption attributes was fixed in https://gerrit.wikimedia.org/r/#/c/44170/. In http://parsoid.wmflabs.org/_rt/es/Anexo:Monumentos_Hist%C3%B3ricos_de_Panam%C3%A1 there are now only a few syntactic diffs (duplicate class attributes removed) left, so I would call this bug fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links