Last modified: 2012-12-26 02:31:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41542, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 39542 - murmur3() error handling of bad parameters
murmur3() error handling of bad parameters
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
E3 Experiments (Other open bugs)
master
All All
: Unprioritized minor (vote)
: ---
Assigned To: Ori Livneh
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-21 21:22 UTC by spage
Modified: 2012-12-26 02:31 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2012-08-21 21:22:31 UTC 
If you pass a number to murmur3() from lib/murmur3.js it returns 0 (with default seed=0); if you pass it null/undefined it throws TypeError.

I'm not sure what the E3 Extension's strategy is for handling errors; caller must validate, return a well-defined error, never fail, throw error, etc. In this case if we want murmur3 to always return a number it could call .toString() on numbers before hashing and hash the string "null" or "undefined" for those values.  I'll document the current requirement; let's discuss.
Comment 1 Ori Livneh 2012-12-26 02:31:24 UTC 
We removed murmur3 from the extension, so I'm closing this.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links