Last modified: 2012-08-29 18:12:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41571, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39571 - Long file names
Long file names
Status: RESOLVED FIXED
Product: WikiLoves Monuments Mobile
Classification: Unclassified
Upload (Other open bugs)
unspecified
All All
: Highest blocker
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-22 21:19 UTC by Jon
Modified: 2012-08-29 18:12 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2012-08-22 21:19:39 UTC
Select the first monument under Belarus and attempt to upload an image here.
The upload fails due to a long file name. 

We should surface this error better and also ensure the filename is never too long.
Comment 1 Jon 2012-08-22 21:36:06 UTC
The error is now surfaced:
https://github.com/wikimedia/WLMMobile/pull/169/files
Comment 2 Jon 2012-08-24 00:13:46 UTC
How was this resolved?
We are showing the error but not preventing this from happening in future.
We need to rethink our filenames.
Comment 3 Arthur Richards 2012-08-24 00:17:15 UTC
My bad, I went through the steps to reproduce since the change you mentioned had been merged and had no problems uploading an image (everything uploaded fine to testwiki), so it seemed this had been resolved.
Comment 4 Jon 2012-08-24 00:23:18 UTC
To be clear the monument in question is called:

			
				 Аўгустоўскі канал:водны шлях, які ўключае зарэгуляваны ўчастак р. Чорная Ганча ад Дзяржаўнай граніцы з Рэспублікай Польшча да в. Сонічы (13 км), штучны ўчастак канала ад в. Сонічы да шлюза«Нямнова» (6,5 км)гідравузел «Нямнова»: 
				 Гарадзенскі раён. Тэрыторыя ў межах матэрыяльнай нерухомай гісторыка-культурнай каштоўнасьці, устаноўленых праектам «Зоны аховы і рэжымы іх утрыманьня гісторыка-культурнай каштоўнасьці «Аўгустоўскі канал»
Comment 5 Arthur Richards 2012-08-24 00:28:08 UTC
The current behavior is to surface an error to the user that the filename is too long, but there is no way to resolve the error since the user has no control over the filename. No good.
Comment 6 Brion Vibber 2012-08-28 06:07:49 UTC
Note that there's actually a limit of 240 UTF-8 bytes enforced!
Comment 7 Brion Vibber 2012-08-28 06:26:04 UTC
Initial stab at https://github.com/wikimedia/WLMMobile/pull/195

The limit is halved and tweaked because we've got some weird limitations in swift for the thumbnails breaking on longer names. :( Not sure exactly what's what there...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links