Last modified: 2014-04-07 18:30:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41577, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 39577 - Toolbar shouldn't appear in view source if page is protected


Summary:	Toolbar shouldn't appear in view source if page is protected

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikiEditor (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Duplicates:	44079 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-08-23 08:48 UTC by Eran Roz
Modified:	2014-04-07 18:30 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Eran Roz 2012-08-23 08:48:53 UTC

Looking in view source mode on a protected page for user who isn't allowed to edit the page shouldn't show toolbar.

Moreover the toolbar even inserts code to the textarea on click...

You can try it in [[en:Main page]] edit (for most users [=non admins there]).

When setting off the enhanced toolbar and trying it again, instead of the "regular" toolbar a message appears ("You can view and copy the source of this page")

(maybe the wikieditor shouldn't be loaded at all in "view source" mode)

Comment 1 Michael M. 2012-08-23 09:27:58 UTC

Only reproducible on en.wikipedia. The function initializeRefTools from [[MediaWiki:Common.js/edit.js]] might be the culprit, since it loads ext.wikiEditor.toolbar unconditionally.

Comment 2 Andre Klapper 2012-12-20 15:08:49 UTC

Confirming.

Comment 3 Andre Klapper 2013-01-18 11:47:46 UTC

*** Bug 44079 has been marked as a duplicate of this bug. ***

Comment 4 Derk-Jan Hartman 2014-04-07 15:57:09 UTC

I fixed this with: https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.js/edit.js&curid=17612478&diff=603166167&oldid=565609564

Comment 5 Helder 2014-04-07 18:30:22 UTC

Verified also on
https://pt.wikipedia.org/wiki/A:CRIAR?action=edit&uselang=en
after a similar fix to
https://pt.wikipedia.org/wiki/MediaWiki:Gadget-refToolbar.js?diff=38608635

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links