Last modified: 2012-08-29 21:58:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41584, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 39584 - [Regression] MediaWiki:Previewnote broken (double html escaped)
[Regression] MediaWiki:Previewnote broken (double html escaped)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: Highest critical (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
: 39770 (view as bug list)
Depends on:
Blocks: 39515
  Show dependency tree / graph
 
Reported: 2012-08-23 10:04 UTC by SpeedyGonsales
Modified: 2012-08-29 21:58 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description SpeedyGonsales 2012-08-23 10:04:36 UTC 
If page

http://hr.wikiquote.org/wiki/MediaWiki:Previewnote

contains image, it is wrongly parsed somewhere and instead of image, output is rendered as broken HTML.

When you save image it is rendered right (on MediaWiki:Previewnote page), but when this message is shown above preview of every page any user edits, it's broken.

1.20wmf10
Comment 2 Ruslan 2012-08-23 10:10:38 UTC 
This message is escaped after it is parsed. This does not seem to be logical.
Comment 3 Niklas Laxström 2012-08-23 10:13:43 UTC 
It's double parsed. Regression in Ifa80db1d81b9b9d1a5adfcac06a9ed14203c100e, should use ->plain() to avoid double parsing.
Comment 4 Alexandre Emsenhuber [IAlex] 2012-08-23 10:18:34 UTC 
Fix pending review in Gerrit change #21180.
Comment 5 Niklas Laxström 2012-08-23 11:00:40 UTC 
Fix merged, pending deployment if deemed necessary.
Comment 6 Rd232 2012-08-24 23:07:26 UTC 
So we have a fix for a critical bug, but no-one can be found to deploy it?? Go to (random image) http://commons.wikimedia.org/w/index.php?title=File:Page_from_the_Wenzel_Bible.jpg&action=submit&uselang=en and then tell me this is not urgent!
Comment 7 Krinkle 2012-08-24 23:32:58 UTC 
The fix is written, reviewed and merged into MediaWiki core.

In order to deploy it right now it has to be backported to the 1.20wmf10 branch, this can be done by anyone with a Gerrit account (no deployment access needed). Then a deployer will approve it and push it live right away.
Comment 8 Alex Monk 2012-08-28 13:56:03 UTC 
(In reply to comment #7)
> In order to deploy it right now it has to be backported to the 1.20wmf10
> branch, this can be done by anyone with a Gerrit account (no deployment access
> needed). Then a deployer will approve it and push it live right away.

Done that in Gerrit change #21730
Comment 9 Alex Monk 2012-08-28 14:29:45 UTC 
Abandoned.
Comment 10 Krinkle 2012-08-28 16:30:22 UTC 
Marking as fixed. Not sure what's wrong with the backport to 1.20wmf10, could be a nasty dependency. Anyway, it'll be deployed automatically during the next branch point 1.20wmf11 since it is fixed in master.

(which will be in 1-2 weeks).
Comment 11 Alex Monk 2012-08-28 16:35:32 UTC 
There's nothing wrong with the fix, Jenkinsbot failed it because of a change to the way tests are run. There was a fix put into master (Gerrit change #20926) but that would also need to be backported to 1.20wmf10 before any other tests on 1.20wmf10 will succeed.
Comment 12 Krinkle 2012-08-29 21:19:08 UTC 
*** Bug 39770 has been marked as a duplicate of this bug. ***
Comment 13 Krinkle 2012-08-29 21:58:12 UTC 
Deployed I2144f026d3b301edb521bf83e1b089de5f35ad64.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links