Last modified: 2013-07-25 07:04:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41590, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39590 - Mark pages that self-transclude as vary-revision so they are not outdated
Mark pages that self-transclude as vary-revision so they are not outdated
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.20.x
All All
: Low normal (vote)
: ---
Assigned To: Bawolff (Brian Wolff)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-23 17:23 UTC by Bawolff (Brian Wolff)
Modified: 2013-07-25 07:04 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2012-08-23 17:23:49 UTC
Its common on templates to transclude themselves as an example in the "noinclude" section.

Of course this self-transclusion uses the previous version of the template, because the template page isn't inserted in the db yet at render time on page-save.

We should mark such pages as "Vary-revision" so that such pages render correctly without requiring a manual purge.

(This of course won't really help circular dependencies, but those aren't common, and you can't fix everything).

Assigning to self as I eventually plan to do this at some point, and this bug is meant as a reminder since I usually forget things I plan to do. However if someone's bored and wants to do this themselves, don't hesitate to fix the bug.
Comment 1 Andre Klapper 2013-01-14 17:16:13 UTC
bawolff: Still working on this? If not feel free to reset the assignee.
Comment 2 Bawolff (Brian Wolff) 2013-01-14 19:24:58 UTC
Wow. Totally forgot I was assigned for this. I am going to try to work on this tomorrow
Comment 3 Bawolff (Brian Wolff) 2013-01-15 22:56:52 UTC
gerrit change Idfac13de
Comment 4 Mark Holmquist 2013-04-27 23:55:15 UTC
Merged! Thanks Brian, and Andre.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links