Last modified: 2012-08-24 18:51:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41619, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39619 - UW is not compatible with the classic skin
UW is not compatible with the classic skin
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-24 14:26 UTC by Derk-Jan Hartman
Modified: 2012-08-24 18:51 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2012-08-24 14:26:20 UTC
UW depends on the following line in it's script:

// scroll to the top of the page (the current step might have been very long, vertically)
		var headScroll = $( '#firstHeading' ).offset();
		$j( 'html, body' ).animate( { scrollTop: headScroll.top, scrollLeft: headScroll.left }, 'slow' );
		

However #firstHeading is not present in the classic skin. Instead it has h1.pagetitle
Comment 1 Mark Holmquist 2012-08-24 14:52:04 UTC
My apologies, this was a case of assuming that the extension operated on only (n - 1) dimensions. Is there a more-universal way of finding the top of the page that we could use?
Comment 2 Derk-Jan Hartman 2012-08-24 15:01:30 UTC
I don't think so. but $( '#firstHeading, h1' ) is probably good enough in this case.
Comment 3 Mark Holmquist 2012-08-24 18:24:32 UTC
https://gerrit.wikimedia.org/r/21341

There ya go.
Comment 4 Mark Holmquist 2012-08-24 18:51:45 UTC
And thanks to sumana, I now have merge rights and can give you this one-line fix for relatively cheap.

Marking as resolved, we'll try to deploy this really soon. Thanks for the report!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links