Last modified: 2012-08-25 20:57:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41626, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 39626 - WLMMobile: incomplete uploads list doesn't update properly after deleting
WLMMobile: incomplete uploads list doesn't update properly after deleting
Status: RESOLVED FIXED
Product: WikiLoves Monuments Mobile
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-24 20:38 UTC by Brion Vibber
Modified: 2012-08-25 20:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2012-08-24 20:38:51 UTC 
Minor regression during development, needs fixing before next release.
Comment 1 Jon 2012-08-25 00:10:55 UTC 
uploadsRendered > db.dirty
always evaluates to true

probably need to update db.dirty...
Comment 2 Brion Vibber 2012-08-25 20:47:16 UTC 
Adding some console.log()s in there... it looks like db.dirty is being updated *after* we re-show the list.

Oh boy... it's because it's calling showUploads() instead of showIncompleteUploads(). *headdesk*
Comment 3 Brion Vibber 2012-08-25 20:48:50 UTC 
https://github.com/wikimedia/WLMMobile/pull/186
Comment 4 Patrick Reilly 2012-08-25 20:57:54 UTC 
 preillyme merged commit c326bac into wikimedia:master from brion:bug39626 just now
 preillyme closed the pull request just now
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links