Last modified: 2012-10-24 06:21:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41681, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39681 - Babel boxes use obsolete attributes cellspacing and cellpadding (in HTML5)
Babel boxes use obsolete attributes cellspacing and cellpadding (in HTML5)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Babel (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Dereckson
http://www.w3.org/TR/2012/WD-html5-di...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-27 09:59 UTC by Michael M.
Modified: 2012-10-24 06:21 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael M. 2012-08-27 09:59:44 UTC
The table constructed by {{#babel:}} uses the attributes cellspacing and cellpadding, which are no longer valid in HTML5 (see URL). Use (inline, in this case) CSS instead.
Comment 1 Dereckson 2012-08-27 10:58:50 UTC
Taking this bug.
Comment 2 Dereckson 2012-08-27 11:01:11 UTC
Reading http://stackoverflow.com/questions/339923/how-to-set-cellpadding-cellspacing-in-css I wonder if it's right now a good idea to drop IE6 and IE7 support.
Comment 3 Siebrand Mazeland 2012-08-27 11:16:15 UTC
(In reply to comment #2)
> Reading
> http://stackoverflow.com/questions/339923/how-to-set-cellpadding-cellspacing-in-css
> I wonder if it's right now a good idea to drop IE6 and IE7 support.

Would you be able to create a screenshot of what IE6/7 would look like if inline CSS were used? Some visual degradation would be acceptable.
Comment 4 Dereckson 2012-08-27 11:26:30 UTC
Yes, I could do it for IE6. I haven't an IE7 install.

I offer to use border-spacing / padding attributes, like in Gerrit change #21567.

This change would also require config change, to have a px (or em) declaration.
Comment 5 Siebrand Mazeland 2012-08-27 11:30:38 UTC
The config change is not desirable (ie acceptable). Based On the current docs of mw:Extension:Babel, things should be backward compat wrt on-wiki configuration.
Comment 6 Dereckson 2012-08-27 11:33:28 UTC
Backwards compatibility could be reached checking if the parameter is an integer, and if so, adding 'px' in CSS declaration.
Comment 7 Dereckson 2012-09-26 08:53:57 UTC
I updated the code, so config change won't be needed.

It will read babel-cellpadding, babel-cellspacing, babel-box-cellpadding. babel-box-cellspacing as pixels values by default.

So a current setting like "8" for babel-cellpadding will become "8px".

Of course, if a user sets "1em" or "0", it will keep the values as is.
Comment 8 Sumana Harihareswara 2012-10-24 05:43:16 UTC
https://gerrit.wikimedia.org/r/#/c/21567/ is now merged; Dereckson, is it ok to close this bug?
Comment 9 Siebrand Mazeland 2012-10-24 06:21:53 UTC
(In reply to comment #8)
> https://gerrit.wikimedia.org/r/#/c/21567/ is now merged; Dereckson, is it ok to
> close this bug?

Absolutely!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links