Last modified: 2013-04-22 16:15:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41685, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 39685 - Apply changes button should be active only if there are changes.


Summary:	Apply changes button should be active only if there are changes.

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	UniversalLanguageSelector (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Amir E. Aharoni

URL:
Whiteboard:
Keywords:	i18n

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-08-27 15:09 UTC by Pau Giner
Modified:	2013-04-22 16:15 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pau Giner 2012-08-27 15:09:59 UTC

The "apply changes" button for the settings dialog should be initially disabled and become active once there is a change in the settings that may be saved by the user.

Comment 1 Siebrand Mazeland 2012-08-28 14:11:46 UTC

We have to discuss this one. Srikanth doesn't see how this can be done given the current degrees of freedom. Let's plan this for a daily or a 3-way chat.

Comment 2 Amir E. Aharoni 2012-11-22 06:27:37 UTC

It doesn't look too hard to me, but I may be missing something.

Here's a proposed fix for the Display Settings panel:
https://gerrit.wikimedia.org/r/#/c/34688/

Comment 3 Amir E. Aharoni 2012-11-22 13:47:37 UTC

And this fix is for Input settings:

https://gerrit.wikimedia.org/r/#/c/34712/

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links