Last modified: 2013-06-21 23:20:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41746, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39746 - UploadWizard needs to quit using funky array magic for upload lists
UploadWizard needs to quit using funky array magic for upload lists
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
master
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: javascript
Depends on:
Blocks: 49987
  Show dependency treegraph
 
Reported: 2012-08-28 19:57 UTC by Mark Holmquist
Modified: 2013-06-21 23:20 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Holmquist 2012-08-28 19:57:34 UTC
I just fixed bug 39608, which was nasty. It looks like this:

https://gerrit.wikimedia.org/r/21820

The reason I had to jump through hoops, as I explained, is partly because we play with the structure of our mw.UploadWizard.uploads array in funny ways.

I'd like to either

1. Change it to be an object, not an array, and stop having to worry about it.

2. Use an array, but don't mess with the order beyond making sure the uploads all appear in the proper sequence (i.e., don't always put them in the same place)

3. Maybe even use an object *with the filenames as indices* and make it easier to find the proper files by the filename (maybe not, this seems like a stretch).

This should happen some other time, because really, it's low-ish priority. But it's a pretty nasty thing.
Comment 1 Dereckson 2012-08-29 10:54:09 UTC
Adding 'javascript' keyword.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links