Last modified: 2012-08-29 20:44:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41771, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39771 - [Regression] ResourceLoader should not serve parsed {{PLURAL:}} tags but leave raw
[Regression] ResourceLoader should not serve parsed {{PLURAL:}} tags but leav...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.20.x
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression, i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-29 18:27 UTC by Mark Holmquist
Modified: 2012-08-29 20:44 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Holmquist 2012-08-29 18:27:51 UTC
In UploadWizard, we have a bunch of messages used in the UI to indicate what's going on with the file or the files. We've been using {{PLURAL}} properly, and that was great.

However, there appears to be a bug with core now. I'm only getting the plural version, never the singular one.

I have been unable to pinpoint the source of the error, since apparently the localisation cache helps to befuddle git-bisect. However, I've been generally convinced that it's a core bug because of the constant state of UploadWizard through my testing.

This is blocking me from writing accurate tests for UploadWizard, sadly, so I'd like to solve this problem soon.

Thanks!
Comment 1 Mark Holmquist 2012-08-29 18:29:25 UTC
Sorry, clarification:

I'm only getting the plural version FROM THE SERVER. The {{PLURAL}} tag is never even stored on the client side when this bug occurs.
Comment 2 Mark Holmquist 2012-08-29 19:47:34 UTC
This bug appears to have been introduced by change I4950fdf8.
Comment 3 Siebrand Mazeland 2012-08-29 20:19:23 UTC
Bug was assigned to me, but I cannot see how or where in gerrir 20666 I could have broken this thing specifically. I'm unassigning, but working with Marc on IRC at the moment.
Comment 4 Siebrand Mazeland 2012-08-29 20:39:56 UTC
Caused by gerrit Ie349afa5. Niklas made a fix in gerrit Iee4e3bdc.
Comment 5 Siebrand Mazeland 2012-08-29 20:44:10 UTC
Confirmed fixed by reporter.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links