Last modified: 2012-10-08 09:07:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41963, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 39963 - jQuery.uls.data. ... function names
jQuery.uls.data. ... function names
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Amir E. Aharoni
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-04 09:30 UTC by Daniel A. R. Werner
Modified: 2012-10-08 09:07 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel A. R. Werner 2012-09-04 09:30:13 UTC 
We noticed that all the members of jQuery.uls.data have changed into functions, which seems a bit strange. In particular, we were using the

jQuery.uls.data.autonyms

Object before which is a function now. Shouldn't it rather be getAutonyms then? Also for the other functions. Is there a reason to have a function here at all other than restricting other parties write access to the data?
Comment 1 Santhosh Thottingal 2012-09-04 12:23:41 UTC 
Yes, functions should use verb and objects should use noun naming patterns. This happened in our data structure refactoring. Previously autonyms was a simple object. but now all language data is merged to ISO 639-3 language code key. For eg: as: [Beng, [AS], অসমীয়া] 

So to abstract this data structure we need functions.

Will be fixed soon.
Comment 2 Amir E. Aharoni 2012-10-07 23:20:36 UTC 
Fixes submitted:

* Component: https://github.com/wikimedia/jquery.uls/pull/9
* Extensions: https://gerrit.wikimedia.org/r/#/c/27124/

Tests will be updated after they stabilize in GitHub.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links