Last modified: 2012-09-06 18:20:09 UTC
Looks like we're getting lots of dates like: "5 May 2007, 00:00:00"
Fixed in https://gerrit.wikimedia.org/r/#/c/22879/
But....what about a picture of the ball dropping on New Year's? That would *have* to be at 00:00:00.... OK, edge case. My point is, it has its use, and it's silly to assume that the default value should be considered null. Agreed that there's some small interest in not including the time when the EXIF data doesn't show it and the user doesn't set it, but simply blacklisting a valid time doesn't appear to be the answer.
Well, you're right, there is a 1 in 86400 chance that the actual time is the default value, but which option is worse: 1. Not showing the time information for 1 in 86400 photos 2. Showing misleading time information for a large number of photos Of course there may be a third option... Something like detect for the case where the date but not the time is set in the EXIF, but that would require more work. I would be happy to see something like that implemented, but I'm not going to have time to look into it further myself :(
I added a FIXME to the code comments to implement a better solution. Going to go ahead and deploy this for now as a stop-gap.
