Last modified: 2013-05-21 22:23:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42004, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 40004 - Parsoid fails with percent-encoded page names in [[ ]]


Summary:	Parsoid fails with percent-encoded page names in [[ ]]

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Mark Holmquist

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-09-05 13:52 UTC by Liangent
Modified:	2013-05-21 22:23 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2012-09-05 13:52:08 UTC

The following wikitext fails. It generates wrong HTML and fails round-trip. Tested on http://parsoid.wmflabs.org/_rtform/ .

[[Wikipedia:%E9%A6%96%E9%A1%B5]]

Comment 1 Gabriel Wicke 2012-09-05 17:53:32 UTC

Thanks for your report!

We'll have to percent-decode the link text. Not sure where the stray %25 comes from here.

Comment 2 Mark Holmquist 2012-10-12 21:34:03 UTC

Change Iba22922c should fix this. Sorry about that!

Comment 3 Mark Holmquist 2012-10-12 22:43:34 UTC

Merged, fixed, bonus points for fixing broken tests. Thanks!

Comment 4 Liangent 2012-10-12 22:49:04 UTC

(In reply to comment #3)
> Merged, fixed, bonus points for fixing broken tests. Thanks!

Not deployed to http://parsoid.wmflabs.org yet, right?

Comment 5 Mark Holmquist 2012-10-12 22:49:46 UTC

No, we just merged it. Gwicke can deploy it shortly I think.

Comment 6 Liangent 2012-10-17 16:50:02 UTC

Sorry but this is still broken for piped links:

[[Wikipedia:%E9%A6%96%E9%A1%B5|A]]

Comment 7 Gabriel Wicke 2012-11-20 05:03:45 UTC

I worked on this recently- seems to be fixed: Tried [[Wikipedia:%E9%A6%96%E9%A1%B5|A]] in http://parsoid.wmflabs.org/_rtform/- round-trips and the HTML link target looks sane to me. But my Chinese is a bit rusty, so please correct me if I am wrong about that ;)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links