Last modified: 2012-12-21 17:23:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42019, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40019 - Delayed merge + mechanical rebase = anonymous merge
Delayed merge + mechanical rebase = anonymous merge
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-05 18:44 UTC by Ryan Kaldari
Modified: 2012-12-21 17:23 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2012-09-05 18:44:31 UTC
Here are the steps to reproduce:
1. +2 a change that has an unmerged dependency (this will cause the merge to be delayed)
2. Rebase the change using the rebase button in Gerrit
3. +2 the dependency

Expected results:
Gerrit should show a checkmark next to the last person who reviewed the commit before it was merged. The email that goes out should say it was merged by the last reviewer.

Actual results:
There is no indication in Gerrit as to who +2ed the revision, indeed there is no code review checkmark at all (https://gerrit.wikimedia.org/r/#/c/22304/). In addition, the email that goes out says that it was merged by Anonymous Coward.
Comment 1 Ori Livneh 2012-12-06 01:00:37 UTC
At minimum, 'Gerrit' could be substituted for 'Anonymous Coward'.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links