Last modified: 2012-09-21 13:27:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42037, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40037 - File related MWTimestamp::setTimestamp : Invalid timestamp exceptions
File related MWTimestamp::setTimestamp : Invalid timestamp exceptions
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.20.x
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 40043 40242 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-06 01:03 UTC by Sam Reed (reedy)
Modified: 2012-09-21 13:27 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2012-09-06 01:03:15 UTC
Brion fixed some of this in https://gerrit.wikimedia.org/r/#/c/22685/

But it seems to be still rather commonly appearing on Commons!

https://commons.wikimedia.org/wiki/File:2012-04_Re%C5%84ska_Wie%C5%9B_26.jpg

2012-09-06 01:02:25 srv279 commonswiki: [53d9f8ff] /wiki/File:2012-04_Re%C5%84ska_Wie%C5%9B_26.jpg   Exception from line 130 of /usr/local/apache/common-local/php-1.20wmf11/includes/Timestamp.php: MWTimestamp::setTimestamp : Invalid timestamp - 1971:01:01 11:30:5500
#0 /usr/local/apache/common-local/php-1.20wmf11/includes/Timestamp.php(75): MWTimestamp->setTimestamp('1971:01:01 11:3...')
#1 /usr/local/apache/common-local/php-1.20wmf11/includes/GlobalFunctions.php(2412): MWTimestamp->__construct('1971:01:01 11:3...')
#2 /usr/local/apache/common-local/php-1.20wmf11/includes/media/FormatMetadata.php(107): wfTimestamp(1, '1971:01:01 11:3...')
#3 /usr/local/apache/common-local/php-1.20wmf11/includes/media/MediaHandler.php(364): FormatMetadata::getFormattedData(Array)
#4 /usr/local/apache/common-local/php-1.20wmf11/includes/media/ExifBitmap.php(138): MediaHandler->formatMetadataHelper(Array)
#5 /usr/local/apache/common-local/php-1.20wmf11/includes/filerepo/file/File.php(1403): ExifBitmapHandler->formatMetadata(Object(LocalFile), 'a:48:{s:4:"Make...')
#6 /usr/local/apache/common-local/php-1.20wmf11/includes/ImagePage.php(138): File->formatMetadata()
#7 /usr/local/apache/common-local/php-1.20wmf11/includes/actions/ViewAction.php(37): ImagePage->view()
#8 /usr/local/apache/common-local/php-1.20wmf11/includes/Wiki.php(427): ViewAction->show()
#9 /usr/local/apache/common-local/php-1.20wmf11/includes/Wiki.php(304): MediaWiki->performAction(Object(ImagePage))
#10 /usr/local/apache/common-local/php-1.20wmf11/includes/Wiki.php(536): MediaWiki->performRequest()
#11 /usr/local/apache/common-local/php-1.20wmf11/includes/Wiki.php(446): MediaWiki->main()
#12 /usr/local/apache/common-local/php-1.20wmf11/index.php(59): MediaWiki->run()
#13 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#14 {main}
Comment 1 Sam Reed (reedy) 2012-09-06 16:51:06 UTC
*** Bug 40043 has been marked as a duplicate of this bug. ***
Comment 2 Brion Vibber 2012-09-06 20:49:43 UTC
https://gerrit.wikimedia.org/r/#/c/22942/
Comment 3 Yann Forget 2012-09-07 03:39:37 UTC
It still apears. See bug 40043.
Comment 4 Derk-Jan Hartman 2012-09-13 13:55:39 UTC
This appears, see https://commons.wikimedia.org/wiki/File:Echinocereus_fendleri_BlKakteenT143.jpg
Comment 5 Alex Monk 2012-09-13 19:42:21 UTC
*** Bug 40242 has been marked as a duplicate of this bug. ***
Comment 6 Umherirrender 2012-09-14 14:09:44 UTC
The problem is, that wfTimestamp changed from false to exception on bogus input, that is a bad idea.

See Gerrit change #23783, which catch the exception and return false in that case to get the old behaviour back.
Comment 7 Umherirrender 2012-09-15 18:43:51 UTC
Gerrit change #23783 is successfully merged. Maybe backport to live site?
Comment 8 Ryan Kaldari 2012-09-19 06:29:04 UTC
It should get deployed to Commons tomorrow (Wednesday).
Comment 9 Marco 2012-09-21 07:31:07 UTC
thx. It is fixed now.
Comment 10 Umherirrender 2012-09-21 13:27:55 UTC
marked as FIXED than.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links