Last modified: 2012-09-27 12:15:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42064, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40064 - Feedback Page - 'Hide My Post' is incorrectly shown to logged-out users
Feedback Page - 'Hide My Post' is incorrectly shown to logged-out users
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: Highest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-06 21:02 UTC by Fabrice Florin
Modified: 2012-09-27 12:15 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Hide my post is incorrectly shown to a logged-out user on Chrome Incognito (144.26 KB, image/png)
2012-09-06 21:04 UTC, Fabrice Florin
Details

Description Fabrice Florin 2012-09-06 21:02:57 UTC
On the Feedback Page, Hide My Post is shown to logged-out users, even though that feature should not be available to them, as stated in our feature requirements:

http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Hide_my_post

The attached mockup shows an example of a logged-out user getting this 'Hide my post' link, even in Chrome Incognito mode (which ignores all cookies).
Comment 1 Fabrice Florin 2012-09-06 21:04:55 UTC
Created attachment 11086 [details]
Hide my post is incorrectly shown to a logged-out user on Chrome Incognito
Comment 2 Fabrice Florin 2012-09-06 21:07:41 UTC
Note that this issue is particularly frustrating because you can't hide your post if you click on this link as a logged-out user. So we are tempting 98% of our users with a link they should not be getting and that will do nothing if they click on it. Let's try to fix this one as soon as possible.

Also note that the flyout tip is still misaligned on all Mac browsers I tried, as shown in this mockup.
Comment 3 Matthias Mullie 2012-09-06 22:04:43 UTC
Mmh, the cause is that we've added in the cookie stuff to not display the toolbox for own feedback.

Should indeed be fixed asap, I'll remove the possibility for logged out users to hide their own feedback (I could also use the cookie to enable this possibility for them, but it could then be abused with forged cookies)
Comment 4 Matthias Mullie 2012-09-06 22:14:42 UTC
Patch pushed to Gerrit (https://gerrit.wikimedia.org/r/#/c/23008/) & prototype

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links