Last modified: 2013-04-22 16:16:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42067, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40067 - When used as a provider, if a user needs to login, then the extension should redirect to the login form
When used as a provider, if a user needs to login, then the extension should ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OpenID (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-07 05:58 UTC by Ryan Lane
Modified: 2013-04-22 16:16 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Lane 2012-09-07 05:58:07 UTC
Currently, if a user needs to login the provider will redirect to Special:OpenIDServer/Login. This is a form that only accepts a user's password. Rather than doing so, it should redirect to the normal login form Special:UserLogin with a returnto parameter that causes Special:UserLogin to return the user back to the OpenID form.

The reason for this is that the wiki could be using other authentication extensions like OATH, LDAP, or CentralAuth, and they won't exist in the Special:OpenIDServer/Login form.
Comment 1 Sumana Harihareswara 2012-12-27 20:34:08 UTC
Tyler, would you be able to take a look at this? Ryan says it's a blocker for using a paste app he'd like to install.
Comment 2 Tyler Romeo 2013-01-08 13:35:12 UTC
https://gerrit.wikimedia.org/r/42757
Comment 3 T. Gries 2013-01-08 13:42:00 UTC
Hello, thanks for the patch.

I will test this - and the code review - as ultra-soon as possible.
Comment 4 T. Gries 2013-01-16 21:57:41 UTC
Tyler, your proposed fix does unfortunately not work. 

It does not make sense, if you supply a patch and cannot test it (you stated in your commit "Unfortunately, I cannot seem to get the OpenID extension working on my test wiki."). 

Please let me know how I could help you to get OpenID working on your own test wiki.
Comment 5 Ryan Lane 2013-01-16 22:33:19 UTC
I've added an openid project in Labs and created an instance that's pre-installed with mediawiki called openid-wiki. Let's coordinate efforts there. Let me know your labsconsole user names and I'll add both of you to the project.
Comment 6 T. Gries 2013-01-19 22:47:28 UTC
"OpenID as a provider

As time goes on we want to tie more web service authentication to Labs' LDAP. It would be ideal to make labsconsole an OpenID provider so that services in Labs can use the same authentication source. OpenID as a provider on labsconsole is blocked by bugs 40068 and 40067."

http://www.mediawiki.org/wiki/Wikimedia_Labs/Account_creation_improvement_project
Comment 7 T. Gries 2013-01-25 22:00:06 UTC
https://gerrit.wikimedia.org/r/#/c/42757/4 looks good and works.
Comment 8 Ryan Lane 2013-01-29 06:04:46 UTC
Let's keep the bug open until the change is actually merged in.
Comment 9 T. Gries 2013-02-09 18:34:28 UTC
fixed in v2.01

https://gerrit.wikimedia.org/r/#/c/46198/
Comment 10 T. Gries 2013-02-10 01:30:53 UTC
The described issue is (for non-wmflabs instances) solved in https://gerrit.wikimedia.org/r/#/c/46198/ .

Ryan; if you discover a new problem, then please file a new bug. the issue you reported with the "OpenID: aborting in ChooseName because identity_url is missing" in the consumer wiki debug log file is a different thing.
Comment 11 T. Gries 2013-02-10 01:34:18 UTC
> Ryan; if you discover a new problem, then please file a new bug. the issue
> you > reported with the "OpenID: aborting in ChooseName because identity_url is
> missing" in the consumer wiki debug log file is a different thing.

filed now as
https://bugzilla.wikimedia.org/show_bug.cgi?id=44834

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links