Last modified: 2012-11-29 12:40:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42077, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 40077 - ApiSetSiteLink needs to verify that the target site is in the correct group
ApiSetSiteLink needs to verify that the target site is in the correct group
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on: 40078
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-07 13:19 UTC by Daniel Kinzler
Modified: 2012-11-29 12:40 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2012-09-07 13:19:36 UTC 
ApiSetItem needs to verify that the target site is in the correct group, that is (for now), that the site is a wikipedia. The same goes for ApiSetSiteLink.

This was previously done by only listing pages in that group as possible values for the respective parameters, but due to the changes to the Sites interface, we are now again accepting all target sites, including wikibooks, etc.
Comment 1 jeblad 2012-09-08 12:11:51 UTC 
Note that this will make it difficult/impossible to link to commons.
Comment 2 Daniel Kinzler 2012-09-08 18:37:39 UTC 
(In reply to comment #1)
> Note that this will make it difficult/impossible to link to commons.

Depends on how groups get set up, and which groups we allow for linking.

For now, all wikis that have inter-language links pointing to Wikipedia should be in the Wikipedia group, I think - that includes Meta, Commons and Species.
Comment 3 Daniel Kinzler 2012-09-10 12:43:22 UTC 
This is already causing trouble, see http://lists.wikimedia.org/pipermail/wikidata-l/2012-September/001031.html
Comment 4 Daniel Kinzler 2012-09-10 13:59:02 UTC 
fix submitted as I4c154bc0
Comment 5 Anja Jentzsch 2012-11-29 12:40:43 UTC 
Verified in Wikidata demo time for sprint 15
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links