Last modified: 2014-02-12 23:38:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42088, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40088 - [GraphViz] graphsize parameter not validated properly.
[GraphViz] graphsize parameter not validated properly.
Status: UNCONFIRMED
Product: MediaWiki extensions
Classification: Unclassified
SemanticResultFormats (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-07 18:54 UTC by Nathan Douglas
Modified: 2014-02-12 23:38 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nathan Douglas 2012-09-07 18:54:24 UTC
My diff utility doesn't seem to be working right (probably some crap with line endings or something), but whatever.

MediaWiki 1.19.1
PHP 5.3.10-1ubuntu3.2 (apache2handler)
MySQL 5.5.24-0ubuntu0.12.04.1
SMW 1.8alpha
SF 2.4.2
SRF 1.8alpha (treeish b1cc82096e)

 The "graphsize" parameter isn't handled correctly, I guess.  You got this:

$params['graphsize'] = new Parameter( 'graphsize', Parameter::TYPE_INTEGER );

around about line 293 of formats/graphviz/SRF_Graph.php.  Doesn't work.  Gonna have a bad time.  All your nodes are great size.  Bad for netbooks.  Bad for America.

This:

$params['graphsize'] = new Parameter( 'graphsize', Parameter::TYPE_STRING, '');

works better.  Something to do with the pointf not being an integer but an ordered pair.  Also, you can remove the li'l

$params['graphsize']->setDefault( '', false );

line.

Now it's good.  Looks pretty.  Good for you.  Good for me.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links