Last modified: 2012-10-17 19:22:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42107, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40107 - ERR want 52e7dd5c76cd4c6e673a9aa6cc7cadee9ad77fb7 not valid
ERR want 52e7dd5c76cd4c6e673a9aa6cc7cadee9ad77fb7 not valid
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-08 16:29 UTC by Platonides
Modified: 2012-10-17 19:22 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Platonides 2012-09-08 16:29:46 UTC
mediawiki-config$ git fetch origin +refs/changes/*:refs/changes/*
fatal: git fetch_pack: expected ACK/NAK, got 'ERR want 52e7dd5c76cd4c6e673a9aa6cc7cadee9ad77fb7 not valid'
fatal: internal server error

Broken server repo? Upgraded gerrit now rejects a previously accepted changeset?

I do have 52e7dd in Working copy. Tested from 4d12ee39 (2012-09-07 17:57:04)
Comment 1 jeremyb 2012-09-08 16:58:50 UTC
Same error here.
Comment 2 Niklas Laxström 2012-09-08 17:02:05 UTC
Have you read Chad's announcement on wikitech-l?
Comment 3 jeremyb 2012-09-08 17:42:22 UTC
Yes, he saw it.
Comment 4 Platonides 2012-09-08 18:31:57 UTC
Seems that the gerrit server misses several patchsets from https://gerrit.wikimedia.org/r/12185

$ ls .git/refs/changes/85/12185
1 2  3  4  8  9  10  11  12  13  14  15  16

and is then trying to get them from the pulling client, which panics.

I have all the blobs, but seems that when trying to pull, it overwrote my local copy of the changes references, since they are now missing here.
Comment 5 Roan Kattouw 2012-09-08 21:19:54 UTC
(In reply to comment #4)
> Seems that the gerrit server misses several patchsets from
> https://gerrit.wikimedia.org/r/12185
> 
> $ ls .git/refs/changes/85/12185
> 1 2  3  4  8  9  10  11  12  13  14  15  16
> 
> and is then trying to get them from the pulling client, which panics.
> 
> I have all the blobs, but seems that when trying to pull, it overwrote my local
> copy of the changes references, since they are now missing here.
The refs are actually present on the server:

root@manganese:/var/lib/gerrit2/review_site/git/operations/mediawiki-config.git/refs/changes/85/12185# ls
1  10  11  12  13  14  15  16  2  3  4  5  6  7  8  9

But the ones that are missing in your clone (5, 6 and 7) point to hashes that are missing:

5:51661c745ae294e736f383e4f5fdc413003b3dfc
6:b77ecd76ea9bdd29733a7763fb6d83083d9e0ed2
7:52e7dd5c76cd4c6e673a9aa6cc7cadee9ad77fb7

For each of these, I get:
# git show 52e7dd5c76cd4c6e673a9aa6cc7cadee9ad77fb7
fatal: bad object 52e7dd5c76cd4c6e673a9aa6cc7cadee9ad77fb7

Whereas the other patchsets point to refs that it did find.

git fsck tells me about these:

# git fsck --full --no-reflogs
error: refs/changes/85/12185/5 does not point to a valid object!
error: refs/changes/85/12185/6 does not point to a valid object!
error: refs/changes/85/12185/7 does not point to a valid object!

This is concerning, because I didn't get these errors before; it looks like somehow Gerrit is losing *more data*.

If you have these three commits locally, could you help me restore them? You can do that as follows:

$ git push Gerrit change #51661c745ae294e736f383e4f5fdc413003b3dfc:refs/heads/sandbox/platonides/12185-5
$ git push gerrit b77ecd76ea9bdd29733a7763fb6d83083d9e0ed2:refs/heads/sandbox/platonides/12185-6
$ git push Gerrit change #52e7dd5c76cd4c6e673a9aa6cc7cadee9ad77fb7:refs/heads/sandbox/platonides/12185-7

This would create branches in your sandbox space that contain these changes, and it should also automatically fix the error because it will cause the relevant commits to come back into existence on manganese.
Comment 6 Chad H. 2012-10-17 14:19:50 UTC
Ping. What's the status on this? I know the commits are still missing since gerrit complains on replication.
Comment 7 Platonides 2012-10-17 16:55:36 UTC
I completely missed Roan reply. :(

Seems I no longer have those objects. In fact, not even the references to any of changes/85/12185 They must have been removed by git gc.

They are there in gitweb, though. We could obtain them from there. Even manually if needed (although that would be quite hard).
Comment 8 Platonides 2012-10-17 18:37:19 UTC
Forget about comment 7, I had been looking at mediawiki/core instead of mediawiki-config. Pushed to the heads mentioned by Roan.
Comment 9 jeremyb 2012-10-17 18:47:09 UTC
Woooooo, WOKSFORME now.

-> FIXED
Comment 10 Chad H. 2012-10-17 18:53:29 UTC
Kicked off a manual replication of the project to the slave to double check. No errors, so this is indeed fixed. Thanks Platonides!
Comment 11 Platonides 2012-10-17 19:22:45 UTC
You are welcome :D

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links