Last modified: 2014-08-18 16:22:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42145, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40145 - incorrect message when trying to move a move-protected page
incorrect message when trying to move a move-protected page
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page protection (Other open bugs)
unspecified
All All
: Low normal (vote)
: 1.24.0 release
Assigned To: Jackmcbarn
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-10 21:46 UTC by Danny
Modified: 2014-08-18 16:22 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Danny 2012-09-10 21:46:22 UTC
When a non-admin user tries to move a move-protected page, they would get the message:

"This page has been protected to prevent editing."

Instead, it should be:

"This page has been protected to prevent moving." (Or, more accurately, ""This page has been protected such that only administrators can move it.")
Comment 1 Dereckson 2012-09-10 21:56:49 UTC
[ Adding easy keyword, -enhancement +bug, low/normal priority ]
Comment 2 Sumana Harihareswara 2012-11-04 03:09:30 UTC
Thanks for the bug report, Danny.

Found the relevant message via git grep -nE :

languages/messages/MessagesEn.php:1034:'protectedpagetext'             => 'This page has been protected to prevent editing.',

So it sounds like either:

* we should edit that message to something like "This page has been protected to prevent editing or moving"  (but then what about deleting or other related actions?)

or

* someone should add a new message in MessagesEn.php (maybe "moveprotectedpage" or a similar key name?) that says "This page has been protected to prevent editing or moving", and alter the relevant references to 'protectedpagetext' to use the new message.
Comment 3 Bartosz Dziewoński 2012-11-30 20:35:29 UTC
Matthew submitted a patch in changeset Ia8a47858.
Comment 4 Matthew Bowker 2012-11-30 21:06:24 UTC
Change has been merged, resolving bug.  

It might be a good idea to add another message in the future, as this would be clearer.
Comment 5 Gerrit Notification Bot 2014-05-08 19:10:46 UTC
Change 125674 had a related patch set uploaded by Jackmcbarn:
Include action in permission error messages

https://gerrit.wikimedia.org/r/125674
Comment 6 Jackmcbarn 2014-05-08 19:11:10 UTC
I don't know why this was ever marked as fixed. It's not fixed.
Comment 7 Gerrit Notification Bot 2014-08-18 14:03:06 UTC
Change 125674 merged by jenkins-bot:
Include action in permission error messages

https://gerrit.wikimedia.org/r/125674
Comment 8 Bartosz Dziewoński 2014-08-18 16:16:04 UTC
Sounds actually fixed now.
Comment 9 Derk-Jan Hartman 2014-08-18 16:22:14 UTC
This might require updates to local and site specific MediaWiki messages to make use of it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links