Last modified: 2014-05-24 01:53:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42254, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40254 - Version number shouldn't always use localized parentheses
Version number shouldn't always use localized parentheses
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.21.x
All All
: Low minor (vote)
: ---
Assigned To: FunPika
: easy, i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-14 17:59 UTC by Liangent
Modified: 2014-05-24 01:53 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2012-09-14 17:59:31 UTC
In some commit version numbers are changed to use localized parentheses however sometimes they're used in English context, for example in a maintenance script it says:

This is MediaWiki version 1.20alpha (b8256e7).

()[ = localized version in zh ] shouldn't be used here.
Comment 1 Siebrand Mazeland 2013-02-12 08:32:27 UTC
Please provide explicit steps to reproduce where this occurs. Otherwise it's really hard to go about resolving this issue.
Comment 2 Daniel Friesen 2013-02-12 08:37:39 UTC
Sounds like some of our maintenance scripts should hardcode a script lang of en.
Comment 3 Liangent 2013-02-15 06:43:37 UTC
(In reply to comment #1)
> Please provide explicit steps to reproduce where this occurs. Otherwise it's
> really hard to go about resolving this issue.

I can't find that specific script now... is it already fixed?
Comment 4 Andre Klapper 2013-02-17 17:52:43 UTC
[resetting status, assuming that Liangent changed it accidentially]
Comment 5 PiRSquared17 2014-02-15 19:48:46 UTC
Where is this?
Comment 6 Andre Klapper 2014-02-26 12:05:06 UTC
Liangent:

Only match when grep'ing is in ./tests/parserTests.php :
  # Print out software version to assist with locating regressions
  $version = SpecialVersion::getVersion();
  echo "This is MediaWiki version {$version}.\n\n";

See https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/includes%2Fspecials%2FSpecialVersion.php#L228 from there.
Comment 7 Liangent 2014-05-06 16:28:50 UTC
(In reply to Andre Klapper from comment #6)
> Liangent:
> 
> Only match when grep'ing is in ./tests/parserTests.php :
>   # Print out software version to assist with locating regressions
>   $version = SpecialVersion::getVersion();
>   echo "This is MediaWiki version {$version}.\n\n";
> 
> See
> https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/
> includes%2Fspecials%2FSpecialVersion.php#L228 from there.

Yeah it is parserTests.php. Spotted again just now when using it.
Comment 8 Gerrit Notification Bot 2014-05-24 01:53:25 UTC
Change 135162 had a related patch set uploaded by FunPika:
Don't localize parentheses in version number in parserTests.php

https://gerrit.wikimedia.org/r/135162

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links