Last modified: 2013-03-11 16:15:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42296, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40296 - action=delete returns 1 when two of them being submitted simultaneously
action=delete returns 1 when two of them being submitted simultaneously
Status: NEW
Product: MediaWiki
Classification: Unclassified
Page deletion (Other open bugs)
1.20.x
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: testme
: 40515 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-17 12:00 UTC by Jimmy Xu
Modified: 2013-03-11 16:15 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jimmy Xu 2012-09-17 12:00:52 UTC
Reproduction:
1. open two action=delete pages,
2. submit those two simultaneously,
3. the latter one would return a page with only "1" as its mw-content-text, instead of cannotdelete.
Comment 1 Liangent 2013-03-11 15:56:17 UTC
*** Bug 40515 has been marked as a duplicate of this bug. ***
Comment 2 Andre Klapper 2013-03-11 16:15:24 UTC
In short: Should be tested on test2.wikipedia.org if it's reproducible.


Copying relevant comments from bug 40515:

--- Comment 0 by Krinkle ---
Aside from it being very wrong that there is only a single character being
output (likely casted from boolean true), there is also:
* No error message at all.
* It did actually succeed (see screenshot)

--- Comment 2 by Krinkle ---

I can't reproduce it because I can't willingly reproduce a rare error in the
file storage backend.

However looking at the code Article::doDelete (which is the only method that
uses the 'cannotdelete-title' message which is shown in the screenshot), I
think this odd interface issue would still be happening just the same.

The $error variable is set to an empty string where documentation expects an
array. It is then never used or set to anything (except by RunHooks) and then
it does "if $error != '': addHtml( $error )"

I don't know what $error ends up being, but whatever it is, it isn't html. So
this is likely being casted to the string '1'.

--- Comment 3 by RobLa ---

No real reason to believe this is file backend related, other than the fact
this happened once on commons.  I'd like to see someone try to repro this on
test2 and commons before assigning this to someone.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links