Last modified: 2012-10-22 21:23:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42299, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40299 - invalid xml node "4::tags" in API response
invalid xml node "4::tags" in API response
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PageCuration (Other open bugs)
master
All All
: High critical (vote)
: ---
Assigned To: bsitu
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-17 14:36 UTC by bianjiang
Modified: 2012-10-22 21:23 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description bianjiang 2012-09-17 14:36:11 UTC
Since Sep. 7, we noticed that the response to the following API calling contains invalid XML piece "<4::tags>..</4:tags>", which breaks XML parser. Could anyone take a look and work on a fix?  Thanks


http://en.wikipedia.org/w/api.php?action=query&format=xml&list=recentchanges&rclimit=1&rcnamespace=0%7C2%7C4%7C6%7C10%7C14%7C100&rcprop=comment%7Cflags%7Cids%7Cloginfo%7Csizes%7Ctimestamp%7Ctitle%7Cuser&rcstart=2012-09-10T19:40:09Z

Response looks like:

<?xml version="1.0"?><api><query><recentchanges><rc type="log" ns="0" title="Artists and Instigators" rcid="527149348" pageid="36976290" revid="0" old_revid="0" user="Breawycker public" oldlen="0" newlen="0" timestamp="2012-09-10T19:40:09Z" comment="" logid="44607537" logtype="pagetriage-deletion" logaction="delete"><4::tags><param>db-g11</param></4::tags></rc></recentchanges></query><query-continue><recentchanges rcstart="2012-09-10T19:40:09Z" /></query-continue></api>
Comment 1 Sam Reed (reedy) 2012-09-17 14:40:51 UTC

*** This bug has been marked as a duplicate of bug 40195 ***
Comment 2 bianjiang 2012-09-17 14:43:44 UTC
Not sure if this is really a duplication of bug 40195. In this case, we are seeing invalid XML node, while in bug  40195, the invalid pieces are in XML attributes.
Comment 3 Sam Reed (reedy) 2012-09-17 15:59:14 UTC
Hmm, yeah, bit quick there.

I'm guessing it's possibly PageTriage related...

logtype="pagetriage-deletion"
Comment 4 Ryan Kaldari 2012-09-17 18:32:34 UTC
I remember Benny explaining to me at some point what this was for, but I can't remember now.
Comment 5 bsitu 2012-09-17 19:37:40 UTC
This is from the new logging documentation:
https://www.mediawiki.org/wiki/Logging_to_Special:Log
Comment 6 Ryan Kaldari 2012-09-18 23:05:57 UTC
Merged
Comment 8 Sam Reed (reedy) 2012-09-19 02:33:50 UTC
(In reply to comment #7)
> the link below still returns invalid pieces, do you need to fix any historical
> data as well?
> 
> http://en.wikipedia.org/w/api.php?action=query&format=xml&list=recentchanges&rclimit=1&rcnamespace=0%7C2%7C4%7C6%7C10%7C14%7C100&rcprop=comment%7Cflags%7Cids%7Cloginfo%7Csizes%7Ctimestamp%7Ctitle%7Cuser&rcstart=2012-09-10T19:40:09Z

Needs merging to production, and then the maintenance script running



For anyone else that cares, https://gerrit.wikimedia.org/r/#/c/24148/
Comment 9 Sam Reed (reedy) 2012-09-19 02:57:45 UTC
https://gerrit.wikimedia.org/r/#/c/24259/
https://gerrit.wikimedia.org/r/#/c/24260/


reedy@fenari:/home/wikipedia/common$ mwscript extensions/PageTriage/tools/cleanupPageTriageLog.php testwiki
processed pagetriage-curation tag: 3
processed pagetriage-curation delete: 1
processed pagetriage-deletion delete: 1
reedy@fenari:/home/wikipedia/common$ mwscript extensions/PageTriage/tools/cleanupPageTriageLog.php enwiki
processed pagetriage-curation tag: 100
processed pagetriage-curation tag: 100
processed pagetriage-curation tag: 100
processed pagetriage-curation tag: 100
processed pagetriage-curation tag: 3
processed pagetriage-curation delete: 100
processed pagetriage-curation delete: 100
processed pagetriage-curation delete: 36
processed pagetriage-deletion delete: 100
processed pagetriage-deletion delete: 100
processed pagetriage-deletion delete: 36


Should only be squid level caching now...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links