Last modified: 2013-01-14 15:45:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42327, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40327 - PID file for pollForChanges does not work with a wiki family setup.
PID file for pollForChanges does not work with a wiki family setup.
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-18 10:44 UTC by Daniel Kinzler
Modified: 2013-01-14 15:45 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2012-09-18 10:44:33 UTC
Using __FILE__ as a basis is not the correct way to get separate pid files for separate wikis, because multiple wikis may use the same install base. This is especially true for the installations run by Wikimedia. Either get the PID file from the command line, or use something like wfWikiID().

Some more minor issues:

I would reserve .lck for actual lock files. This is not really a lock file. .pid is often used on unix for this, look into your /var/run directory for examples.

Under *nix, it would be nicer to use a file in /var/run (you will see a whole bunch of .pid files there already). The file in /var/run would need to be created and chowned to the correct user for that to work though.

Perhaps just try to use /var/run/xyz first (check whether the dir exist and the file is writable / can be created), otherwise use the OS' temp dir.
Comment 1 Daniel Kinzler 2012-09-18 11:08:42 UTC
For reference, the PID stuff was introduced by I82973368.
Comment 2 tobias.gritschacher 2012-09-18 14:12:18 UTC
done in https://gerrit.wikimedia.org/r/#/c/24122/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links