Last modified: 2014-11-07 11:54:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42379, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40379 - Set user language to current UI language when creating accounts, not only when defined by uselang
Set user language to current UI language when creating accounts, not only whe...
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, i18n, need-volunteer
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-20 09:08 UTC by Daniel Kinzler
Modified: 2014-11-07 11:54 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2012-09-20 09:08:20 UTC
When using something like the Universal Language Selector to give anonymous users a persistent user language, the user should just keep that language when creating an account.

Technically, this means initializing the new user's language setting to the current UI setting.
Comment 1 Mark Holmquist 2012-09-21 21:41:03 UTC
Rohit, I know you were looking at this bug, so I'm assigning it to you in case someone else thinks about working on it. If you drop it, unassign yourself and no hard feelings :)

Remember to come and hang out in #mediawiki if you need any help!
Comment 2 Siebrand Mazeland 2012-11-09 11:14:30 UTC
Unassigning. No apparent progress.
Comment 3 Tyler Romeo 2013-02-14 07:51:05 UTC
Maybe I'm confused, but doesn't the account creation form already do this? (In LoginForm::addNewAccount on line 247 it sets the user's language.)
Comment 4 Siebrand Mazeland 2013-02-14 09:31:18 UTC
"A" language is set, being uselang, per:

105: $this->mLanguage = $request->getText( 'uselang' );

However, with for example ULS, there are other options that determine the language. setlang could be one, the value of the language cookie or the value of the Accept-Language.
Comment 5 Tyler Romeo 2013-02-14 10:03:09 UTC
Aha I see.
Comment 6 Andre Klapper 2013-10-31 12:17:11 UTC
[replacing wikidata keyword by adding CC - see bug 56417]
Comment 7 Stephen Zhou 2014-03-07 02:20:00 UTC
Hi. Just to clarify: this bug is to address the fact that user language preference is not set upon account creation after choosing a language via the ULS? So the changes should be done in ULS, not SpecialUserLogin?
Comment 8 Nemo 2014-03-07 07:03:32 UTC
(In reply to Stephen Zhou from comment #7)
> Hi. Just to clarify: this bug is to address the fact that user language
> preference is not set upon account creation after choosing a language via
> the ULS? So the changes should be done in ULS, not SpecialUserLogin?

No. Comment 0 says "something like the Universal Language Selector", more common in the wild is setting [[mw:uselang]]. The login/signup process itself needs to set in the language preference of the newly created account whatever language is the interface language.
Comment 9 Stephen Zhou 2014-03-08 05:55:26 UTC
Ah, I see. Makes sense now.

It looks like uselang is already handled, so what needs to be handled in addition is setlang, the wikilanguage cookie, and Accept-Language value like Siebrand mentioned. The cookie one was not hard so I'll just figure out the other two. Thanks!
Comment 10 Gerrit Notification Bot 2014-03-25 09:28:18 UTC
Change 120475 had a related patch set uploaded by Nemo bis:
Tries to use wikilanguage cookie, HTTP request Accept Header, and then the get preferred variant in that order

https://gerrit.wikimedia.org/r/120475

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links