Last modified: 2012-09-21 03:11:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42415, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 40415 - Add missing dependencies for modules "mediawiki.user" and "mediawiki.action.view.dblClickEdit"


Summary:	Add missing dependencies for modules "mediawiki.user" and "mediawiki.action.v...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	JavaScript (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	1.20.0 release
Assigned To:	Helder

URL:
Whiteboard:
Keywords:	easy, javascript

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-09-20 21:30 UTC by Helder
Modified:	2012-09-21 03:11 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2012-09-20 21:30:55 UTC

I think the module "mediawiki.user"
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/Resources.php;h=5156dd04374d2f4c53582833d5bf32ce1dcb316d;hb=HEAD#l624
should have "user.tokens" as dependecy because of this line:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/mediawiki/mediawiki.user.js#l249
 249         mw.user = new User( mw.user.options, mw.user.tokens );


Also, the module
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js
uses mw.util.$content, so it should have 'mediawiki.page.startup' as dependency:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/Resources.php;h=5156dd04374d2f4c53582833d5bf32ce1dcb316d;hb=HEAD#l661

Comment 1 Krinkle 2012-09-20 21:41:41 UTC

Nice catch, to both.

Just for your information though. The dependency on mediawiki.user is not subject to the usual race condition because user.tokens is embedded into the HTML output.

Comment 2 Krinkle 2012-09-20 21:42:40 UTC

if you like, put up a patchset on gerrit. Otherwise, I'll assign for next week.

(btw, removing from component ResourceLoader, onto MediaWiki core > JavaScript. This is not related to the ResourceLoader framework, but the javascript modules in mediawiki itself).

Comment 3 Helder 2012-09-21 00:50:36 UTC

Gerrit Change I5ef5e4ab

Comment 4 Krinkle 2012-09-21 03:11:23 UTC

Landed in master.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links