Last modified: 2012-11-27 22:16:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42463, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40463 - VisualEditor: Various actions that trigger retrieval of offsets throw uncaught exceptions
VisualEditor: Various actions that trigger retrieval of offsets throw uncaugh...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2012-11-26
Assigned To: Rob Moen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-24 01:51 UTC by Krinkle
Modified: 2012-11-27 22:16 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2012-09-24 01:51:23 UTC
Little hard to reproduce but has come up several times. Selecting some text, playing around with the inspector and pasting some text.

Stack:

Uncaught TypeError: Cannot call method 'canHaveChildren' of null
> ve.dm.Document.getNodeFromOffset
> ve.ui.Toolbar.updateTools
> ve.EventEmitter.emit
> ve.dm.Surface.change
> ve.ce.Surface.onPaste
> jQuery.extend.proxy.proxy
> jQuery.event.dispatch
> jQuery.event.add.elemData.handle.eventHandle


ve.dm.Document.prototype.getNodeFromOffset = function(offset) {
        var node = this.documentNode.getNodeFromOffset(offset);
        if (!node.canHaveChildren
Uncaught TypeError: Cannot call method 'canHaveChildren' of null
        ()) {
            node = node.getParent();
        }
        r
Comment 1 James Forrester 2012-09-24 17:29:25 UTC
Thought this one got fixed, but clearly not. :-)
Comment 2 Krinkle 2012-10-01 21:30:29 UTC
Aside from Surface.change, Surface.showSelection also has a similar problem:

http://cl.ly/image/1v1h3f2M2722
Comment 3 James Forrester 2012-11-13 18:41:19 UTC
Pushing to next milestone as they did not make it to master by yesterday.
Comment 4 Trevor Parscal 2012-11-27 22:16:30 UTC
This was fixed in Ia7347527e6466262e819f456404b32926fd95e34

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links